You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by arpadboda <gi...@git.apache.org> on 2018/11/29 12:35:26 UTC
[GitHub] nifi-minifi-cpp pull request #453: POF: static property improvements
GitHub user arpadboda opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/453
POF: static property improvements
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arpadboda/nifi-minifi-cpp Static_property_improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/453.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #453
----
commit d2ffd85546ea3dd927e86234f1eb45bc08cf20d0
Author: Arpad Boda <ab...@...>
Date: 2018-11-29T09:36:09Z
POF: static property improvements
----
---
[GitHub] nifi-minifi-cpp issue #453: POF: static property improvements
Posted by arpadboda <gi...@git.apache.org>.
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/453
Overview:
-Please read tests first. They should give an idea of the motivation of the change
-This is POF, some parts of the code might leave space for improvement, some are not yet implemented.
Pros of suggested solution:
-Fully backward-compatible, no change required in processors.
-All property types can be assigned to Property (string property) without loosing the validator.
-Values are still stored in string, so no change in overhead of getter
-Easily extendable with further validators, properties
-Validators can provide data in any format for server-side validation, no duplication of data
Cons:
-Templates, templates, templates everywhere... Added some static asserts to help development with meaningful error messages.
---
[GitHub] nifi-minifi-cpp issue #453: POF: static property improvements
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/453
Thanks for submitting this. I think there is definite overlap between work I previously had with MINIFICPP-479 (https://github.com/apache/nifi-minifi-cpp/compare/master...phrocker:MINIFICPP-479?expand=1) I collected commits from across computers and squashed them, but has the side effect that it does validation at flow file load time ( something we've desperately needed) -- giving us a much earlier failure. a bit different implementation -- and it informs c2 of java validators to be used.
what is the motivation of this PR beyond that work that we discussed offline? I think the same "pros" exist for both works. That work has been around since June -- so it's probably stale in its ideas, so I'll take a look at this at some point. Thanks again.
---