You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/08/04 20:09:59 UTC

[GitHub] [trafficcontrol] lbathina commented on a change in pull request #3772: CIAB: add sanity checks around x509 file existence

lbathina commented on a change in pull request #3772: CIAB: add sanity checks around x509 file existence
URL: https://github.com/apache/trafficcontrol/pull/3772#discussion_r310401799
 
 

 ##########
 File path: infrastructure/cdn-in-a-box/traffic_ops/run-go.sh
 ##########
 @@ -87,6 +87,12 @@ while true; do
 done
 
 ### Add SSL keys for demo1 delivery service
+until [[ -s "$X509_DEMO1_CERT_FILE" && -s "$X509_DEMO1_REQUEST_FILE" && -s "$X509_DEMO1_KEY_FILE" ]]
+do
+  echo "Waiting on X509_DEMO1 files to exist"
+  sleep 3
 
 Review comment:
   would result in possible infinite loop if the file did not exist for some reason. its better to loop for certain duration or until the file exists. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services