[GitHub] [iceberg] rdblue commented on pull request #6139: Python: Remove dataclasses

[GitBox <gi...@apache.org>]

rdblue commented on PR #6139:
URL: https://github.com/apache/iceberg/pull/6139#issuecomment-1320982239

   I took a close look at the type with binding and I think that this is probably the best way to go forward. I tried adding more specific types, like a type for the bound expression in case it was different, but it didn't seem to matter much to mypy so going with a single type param for unbound expressions seems to work the best. I also wasn't able to remove the ignore annotation in the constructors.
   
   Merged this. Thanks for all the work here, @Fokko! I'll rebase my expression PR on this and also open one to fix a few of the nits.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org