You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/16 02:00:22 UTC
[GitHub] [incubator-kyuubi] wForget opened a new pull request, #2660: [KYUUBI #2543] Make rowCountPerTask configurable
wForget opened a new pull request, #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
close #2543
### _How was this patch tested?_
- [X] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#discussion_r873342163
##########
extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSTable.scala:
##########
@@ -68,8 +68,13 @@ class TPCDSTable(tbl: String, scale: Int, options: CaseInsensitiveStringMap)
override def capabilities(): util.Set[TableCapability] =
Set(TableCapability.BATCH_READ).asJava
- override def newScanBuilder(options: CaseInsensitiveStringMap): ScanBuilder = {
- new TPCDSBatchScan(tpcdsTable, scale, schema)
+ override def newScanBuilder(scanOpts: CaseInsensitiveStringMap): ScanBuilder = {
+ val map = new util.HashMap[String, String](scanOpts)
+ options.asScala.foreach {
+ case (k, v) => map.putIfAbsent(k, v)
+ }
+ val newOpts = new CaseInsensitiveStringMap(map)
Review Comment:
It's good to consider both SparkConf and ReadOption, can we extract it such as `org.apache.iceberg.spark.SparkConfParser`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#issuecomment-1127353735
https://github.com/trinodb/tpcds/issues/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on a diff in pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
wForget commented on code in PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#discussion_r873356375
##########
extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSTable.scala:
##########
@@ -68,8 +68,13 @@ class TPCDSTable(tbl: String, scale: Int, options: CaseInsensitiveStringMap)
override def capabilities(): util.Set[TableCapability] =
Set(TableCapability.BATCH_READ).asJava
- override def newScanBuilder(options: CaseInsensitiveStringMap): ScanBuilder = {
- new TPCDSBatchScan(tpcdsTable, scale, schema)
+ override def newScanBuilder(scanOpts: CaseInsensitiveStringMap): ScanBuilder = {
+ val map = new util.HashMap[String, String](scanOpts)
+ options.asScala.foreach {
+ case (k, v) => map.putIfAbsent(k, v)
+ }
+ val newOpts = new CaseInsensitiveStringMap(map)
Review Comment:
Sounds good, I will try it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
wForget commented on PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#issuecomment-1127195360
cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#issuecomment-1135356531
Thanks @wForget, don't forget to update the umbrella since we change the plan :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
wForget commented on PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#issuecomment-1135353077
https://github.com/apache/incubator-kyuubi/issues/2543#issuecomment-1132427303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget commented on pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
wForget commented on PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#issuecomment-1135362269
> Thanks @wForget, don't forget to update the umbrella since we change the plan :)
Thank you for your reminder. I will update the issue title and umbrella.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#issuecomment-1127185786
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2660](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b4fcf4) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f16ac8be9fba238541b0a628a8fa8b4db47050bd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f16ac8b) will **increase** coverage by `0.02%`.
> The diff coverage is `83.33%`.
```diff
@@ Coverage Diff @@
## master #2660 +/- ##
============================================
+ Coverage 64.26% 64.29% +0.02%
- Complexity 82 83 +1
============================================
Files 385 385
Lines 18642 18660 +18
Branches 2526 2529 +3
============================================
+ Hits 11980 11997 +17
+ Misses 5518 5516 -2
- Partials 1144 1147 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/spark/connector/tpcds/TPCDSTable.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstY29ubmVjdG9yLXRwY2RzL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NwYXJrL2Nvbm5lY3Rvci90cGNkcy9UUENEU1RhYmxlLnNjYWxh) | `68.29% <80.00%> (+0.72%)` | :arrow_up: |
| [.../kyuubi/spark/connector/tpcds/TPCDSBatchScan.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstY29ubmVjdG9yLXRwY2RzL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NwYXJrL2Nvbm5lY3Rvci90cGNkcy9UUENEU0JhdGNoU2Nhbi5zY2FsYQ==) | `82.75% <100.00%> (ø)` | |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `83.60% <0.00%> (-1.64%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `68.00% <0.00%> (-1.34%)` | :arrow_down: |
| [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `85.48% <0.00%> (+1.61%)` | :arrow_up: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `71.26% <0.00%> (+4.59%)` | :arrow_up: |
| [...k/authz/ranger/RuleReplaceShowObjectCommands.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1Ymktc3BhcmstYXV0aHovc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvcGx1Z2luL3NwYXJrL2F1dGh6L3Jhbmdlci9SdWxlUmVwbGFjZVNob3dPYmplY3RDb21tYW5kcy5zY2FsYQ==) | `62.06% <0.00%> (+5.25%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f16ac8b...0b4fcf4](https://codecov.io/gh/apache/incubator-kyuubi/pull/2660?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#issuecomment-1127321844
I notice that trinodb/tpcds has a hardcode restriction for split, let's add some comments as well.
https://github.com/trinodb/tpcds/blob/8a02abbba864feedc2afd078c8153d66a95bb2d4/src/main/java/io/trino/tpcds/Parallel.java#L26-L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] wForget closed pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
Posted by GitBox <gi...@apache.org>.
wForget closed pull request #2660: [KYUUBI #2543] Make rowCountPerTask configurable
URL: https://github.com/apache/incubator-kyuubi/pull/2660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org