You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/07 09:24:30 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #5819: [INLONG-5818][Sort] Fix pulsar connector metric computing

healchow commented on code in PR #5819:
URL: https://github.com/apache/inlong/pull/5819#discussion_r964604660


##########
inlong-sort/sort-formats/format-inlongmsg-base/src/main/java/org/apache/inlong/sort/formats/inlongmsg/InLongMsgDeserializationSchema.java:
##########
@@ -38,6 +39,8 @@
 
 public class InLongMsgDeserializationSchema implements DeserializationSchema<RowData> {
 
+    private static final Logger log = LoggerFactory.getLogger(InLongMsgDeserializationSchema.class);

Review Comment:
   For static final variable, suggest using UPPER case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org