You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/07/13 20:29:10 UTC

[GitHub] [maven] MartinKanters commented on a change in pull request #340: [MNG-5571] Resume from generates misleading hint when multiple projects fail.

MartinKanters commented on a change in pull request #340:
URL: https://github.com/apache/maven/pull/340#discussion_r453912852



##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
##########
@@ -1031,20 +1032,21 @@ private int execute( CliRequest cliRequest )
                 }
             }
 
-            if ( !failedProjects.isEmpty() )
+            List<MavenProject> sortedProjects = result.getTopologicallySortedProjects();
+            if ( result.canResume() )
+            {
+                logBuildResumeHint( "mvn <args> -r " );

Review comment:
       Nice find! I don't think it's intentional and it has not been introduced in this PR, but it does not look like any the feature or integration tests will be impacted by removing the trailing space. I'll get rid of it.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org