You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Zhong Wang (JIRA)" <ji...@apache.org> on 2010/11/03 09:30:26 UTC
[jira] Created: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
FSDirectory.removeBlock() should update diskspace count of the block owner node
-------------------------------------------------------------------------------
Key: HDFS-1487
URL: https://issues.apache.org/jira/browse/HDFS-1487
Project: Hadoop HDFS
Issue Type: Bug
Components: name-node
Affects Versions: 0.21.0, 0.20.2, 0.20.1
Reporter: Zhong Wang
Fix For: 0.22.0
This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1487:
------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to branch 22.
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: hdfs-1487-1.patch, HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Zhong Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhong Wang updated HDFS-1487:
-----------------------------
Status: Open (was: Patch Available)
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.21.0, 0.20.2, 0.20.1
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Zhong Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhong Wang updated HDFS-1487:
-----------------------------
Attachment: HDFS-1487.patch
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1487:
------------------------------
Attachment: (was: hdfs-1487-b20-1.patch)
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: hdfs-1487-1.patch, HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Zhong Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhong Wang updated HDFS-1487:
-----------------------------
Attachment: HDFS-1487.patch
New patch attached with test case. Run Hudson.
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1487:
------------------------------
Attachment: hdfs-1487-b20-1.patch
Patch for branch 20 attached.
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: hdfs-1487-1.patch, hdfs-1487-b20-1.patch, HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-1487) FSDirectory.removeBlock() should
update diskspace count of the block owner node
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins reassigned HDFS-1487:
---------------------------------
Assignee: Zhong Wang
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Assignee: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: hdfs-1487-1.patch, HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1487) FSDirectory.removeBlock() should
update diskspace count of the block owner node
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933280#action_12933280 ]
Eli Collins commented on HDFS-1487:
-----------------------------------
{noformat}
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 release audit. The applied patch generated 103 release audit warnings (more than the trunk's current 1 warnings).
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
[exec]
{noformat}
Release audit is not due to this patch.
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: hdfs-1487-1.patch, HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1487) FSDirectory.removeBlock() should
update diskspace count of the block owner node
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933275#action_12933275 ]
Eli Collins commented on HDFS-1487:
-----------------------------------
I forgot to add that in my patch I pass true for checkQuota, since it should be checked by default (not that it would necessarily fire here since we're subtracting from the quota).
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: hdfs-1487-1.patch, HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Zhong Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhong Wang updated HDFS-1487:
-----------------------------
Status: Patch Available (was: Open)
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.21.0, 0.20.2, 0.20.1
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Zhong Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhong Wang updated HDFS-1487:
-----------------------------
Status: Patch Available (was: Open)
Patch attached for review. Fix the bug and add a warning message when quota is violated. I have tested on my cluster and it works ok. I will add a test case soon, maybe in TestAbandonBlock.java. Any suggestions?
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.21.0, 0.20.2, 0.20.1
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-1487) FSDirectory.removeBlock() should update
diskspace count of the block owner node
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-1487:
------------------------------
Attachment: hdfs-1487-1.patch
+1 Good catch Zhong.
Patch attached is rebased against HDFS-1507, I made the test junit4 style. Also removed the warning in FSDirectory; the patch I wrote for HDFS-1377 has an something which we can discuss there or in a separate jira.
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: hdfs-1487-1.patch, HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1487) FSDirectory.removeBlock() should
update diskspace count of the block owner node
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933284#action_12933284 ]
Eli Collins commented on HDFS-1487:
-----------------------------------
I've committed this. Will merge to 22 when the branch has been created. Thanks Zhong!
> FSDirectory.removeBlock() should update diskspace count of the block owner node
> -------------------------------------------------------------------------------
>
> Key: HDFS-1487
> URL: https://issues.apache.org/jira/browse/HDFS-1487
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.1, 0.20.2, 0.21.0
> Reporter: Zhong Wang
> Fix For: 0.22.0
>
> Attachments: hdfs-1487-1.patch, HDFS-1487.patch, HDFS-1487.patch
>
>
> This bug leads a quota computation error. When calling abandonBlock(), the cached diskspace count of INodeDirectoryWithQuota is larger than the actual consumed space value.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.