[GitHub] [superset] squalou commented on a diff in pull request #23476: fix(excel export) #23375 set columns numeric datatypes on excel export

["squalou (via GitHub)" <gi...@apache.org>]

squalou commented on code in PR #23476:
URL: https://github.com/apache/superset/pull/23476#discussion_r1147240810


##########
superset/common/query_context_processor.py:
##########
@@ -457,11 +458,17 @@ def get_data(self, df: pd.DataFrame) -> Union[str, List[Dict[str, Any]]]:
 
             result = None
             if self._query_context.result_format == ChartDataResultFormat.CSV:
-                result = csv.df_to_escaped_csv(
-                    df, index=include_index, **config["CSV_EXPORT"]
-                )
-            elif self._query_context.result_format == ChartDataResultFormat.XLSX:
-                result = excel.df_to_excel(df, **config["EXCEL_EXPORT"])
+                ndf = df.copy()
+                columns = list(df)
+                i = 0
+                for c in columns:
+                    coltype = None
+                    if i<len(coltypes):
+                        coltype = coltypes[i]
+                        if coltype == GenericDataType.NUMERIC:
+                            ndf[c] = pd.to_numeric(df[c], errors='ignore')
+                    i+=1
+                result = excel.df_to_excel(ndf, **config["EXCEL_EXPORT"])

Review Comment:
   that's an error when reporting my local tweaks to the fork, sorry for that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org