[jira] [Commented] (TINKERPOP-1797) LambdaRestrictionStrategy and LambdaMapStep in `by()`-modulation.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197339#comment-16197339 ] 

ASF GitHub Bot commented on TINKERPOP-1797:
-------------------------------------------

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/730

    TINKERPOP-1797: LambdaRestrictionStrategy and LambdaMapStep in by()-modulation.

    https://issues.apache.org/jira/browse/TINKERPOP-1797
    
    We have had too many problems with `LambdaRestrictionStrategy` because it is difficult to know what is a true lambda. I have now simply hardcoded the lambda determination as a `String` analysis of the lambda object for Java, Groovy, and Python. As we add more GLVs, we can add more string mappers. Every other solution thus far has either been too lenient or too restrictive.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1797

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #730
    
----
commit 46ac055f747390eefb58ac7ab7ef4c9fc178aaec
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-10-09T17:20:26Z

    We have had so many problems with LambdaRestrictionStragegy because it is difficult to know what is a true lambda. I have now simply hardcoded the lambda determination as a String analysis of the lambda object for Java, Groovy, and Python. As we add more GLVs, we can add more string mappers. Any other solution thus far has either been too lenient or too restrictive. Added more test cases to LambdaRestrictionStrategyTest as well.

----


> LambdaRestrictionStrategy and LambdaMapStep in `by()`-modulation.
> -----------------------------------------------------------------
>
>                 Key: TINKERPOP-1797
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1797
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.2.6
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>
> {code}
> gremlin> g.V().groupCount().by(label).order(local).by(values)
> The provided step contains a lambda comparator: OrderLocalStep([[[LambdaMapStep(values)@[~gremlin.incidentToAdjacent, ~gremlin.pathRetraction]], incr]])
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)