You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/12 21:02:26 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #2812: Spark: Use JavaSparkContext.fromSparkContext instead the constructor
aokolnychyi opened a new pull request #2812:
URL: https://github.com/apache/iceberg/pull/2812
As @RussellSpitzer pointed out during reviews, it is better avoid calling `new` to construct `JavaSparkContext` not to mislead people as we are not actually creating a new context. Instead, we create a wrapper.
This PR updates places that were committed before that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #2812: Spark: Use JavaSparkContext.fromSparkContext instead of constructor
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #2812:
URL: https://github.com/apache/iceberg/pull/2812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2812: Spark: Use JavaSparkContext.fromSparkContext instead of constructor
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2812:
URL: https://github.com/apache/iceberg/pull/2812#issuecomment-878594550
@RussellSpitzer, could you review this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #2812: Spark: Use JavaSparkContext.fromSparkContext instead of constructor
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #2812:
URL: https://github.com/apache/iceberg/pull/2812#issuecomment-878729361
Thanks, @kbendick @RussellSpitzer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org