You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/04/17 10:13:24 UTC
[GitHub] [skywalking-rocketbot-ui] horber opened a new pull request #474: endpoint component enhanced in trace-search
horber opened a new pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474
refer to commit notes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822236984
However, I found that many components in the project seem to have no reuse mechanism and will be rebuilt in a large number, so that there will be problems with binding shortcuts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r616703150
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -132,16 +141,12 @@ limitations under the License. -->
private maxTraceDuration: string = localStorage.getItem('maxTraceDuration') || '';
private minTraceDuration: string = localStorage.getItem('minTraceDuration') || '';
private instance: Option = { label: 'All', key: '' };
- private endpointName: string = localStorage.getItem('endpointName') || '';
+ private endpoint: Option = { label: 'All', key: '' };
private traceId: string = localStorage.getItem('traceId') || '';
private traceState: Option = { label: 'All', key: 'ALL' };
private tags: string = '';
private tagsList: string[] = [];
-
private created() {
- this.endpointName = this.$route.query.endpointname
- ? this.$route.query.endpointname.toString()
- : this.endpointName;
Review comment:
@Fine0830 Please confirm, after this change, whether endpoint id is not required in the query? If so, I am willing to remove it from query protocol if the CLI side is fine with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822250692
> However, I found that many components in the project seem to have no reuse mechanism and will be rebuilt in a large number, so that there will be problems with binding shortcuts
Huh, show your code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-823941931
all fix, please check @Fine0830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822203764
Actually, I prefer to search traces by entering key, but I don't feel it easy to add Keyup event , I find that the component has been created many times and not destroyed, which will result in multiple binding events and can't be unbound. I wonder if you have found this problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r617283894
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +170,34 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
Review comment:
The same thing as following.
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -15,7 +15,7 @@ limitations under the License. -->
<template>
<div class="rk-trace-search">
- <div>
+ <div class="pb-15 pt-5">
Review comment:
Could you set the `padding-bottom` to `5px`?
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +170,34 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
+ this.GET_ITEM_ENDPOINTS({
+ serviceId: i.key,
+ keyword: '',
+ duration: this.durationTime,
+ }).then((data: Array<{ key: string; label: string }>) => {
+ (this.rocketTrace as any).endpoints = data;
Review comment:
Please set `state` data in modules, Here is `src/store/modules/trace/index.ts`;
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +170,34 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
+ this.GET_ITEM_ENDPOINTS({
+ serviceId: i.key,
+ keyword: '',
+ duration: this.durationTime,
+ }).then((data: Array<{ key: string; label: string }>) => {
+ (this.rocketTrace as any).endpoints = data;
+ this.$forceUpdate();
+ });
}
-
private chooseStatus(i: any) {
this.traceState = i;
}
-
+ private chooseEndpoint(i: any) {
Review comment:
Could you use `Option` instead `any`? `import { Option } from '@/types/global';`
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +170,34 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
+ this.GET_ITEM_ENDPOINTS({
+ serviceId: i.key,
+ keyword: '',
+ duration: this.durationTime,
+ }).then((data: Array<{ key: string; label: string }>) => {
+ (this.rocketTrace as any).endpoints = data;
+ this.$forceUpdate();
+ });
}
-
private chooseStatus(i: any) {
Review comment:
Could you use `Option` instead `any`? `import { Option } from '@/types/global';`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822141044
Make sense. @Fine0830 Could you verify the codes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r617283894
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +170,34 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
Review comment:
The same thing as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r616599212
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -132,16 +141,12 @@ limitations under the License. -->
private maxTraceDuration: string = localStorage.getItem('maxTraceDuration') || '';
private minTraceDuration: string = localStorage.getItem('minTraceDuration') || '';
private instance: Option = { label: 'All', key: '' };
- private endpointName: string = localStorage.getItem('endpointName') || '';
+ private endpoint: Option = { label: 'All', key: '' };
private traceId: string = localStorage.getItem('traceId') || '';
private traceState: Option = { label: 'All', key: 'ALL' };
private tags: string = '';
private tagsList: string[] = [];
-
private created() {
- this.endpointName = this.$route.query.endpointname
- ? this.$route.query.endpointname.toString()
- : this.endpointName;
Review comment:
After delete this, we aren't able to visit a link with endpointName, link trace id. Should we keep this? @wu-sheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r617362274
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +170,34 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
+ this.GET_ITEM_ENDPOINTS({
+ serviceId: i.key,
+ keyword: '',
+ duration: this.durationTime,
+ }).then((data: Array<{ key: string; label: string }>) => {
+ (this.rocketTrace as any).endpoints = data;
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822137416
> The list of endpoints can be obtained through the service key, so it may be more user-friendly to support the drop-down box selection. Otherwise, the search efficiency may be reduced by forgetting which endpoint names exist
This makes sense to me. Just please provide the screenshot to show it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822135448
The list of endpoints can be obtained through the service key, so it may be more user-friendly to support the drop-down box selection. Otherwise, the search efficiency may be reduced by forgetting which endpoint names exist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822175843
I have checked this and have found the following problems
1. The component style of `TraceSearch` is wrong.
2. When we select a service, the logic should only fetch endpoints and instance of this service, rather than fetching services, endpoints and instance of this service, traces.
3. Set a default value for endpoints name. Should we add `All` in endpoints selector? @wu-sheng
Please fix those. Thank you for your contribution @horber.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r617134274
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +176,40 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
+ this.GET_ITEM_ENDPOINTS({
+ serviceId: i.key,
+ keyword: '',
+ duration: this.durationTime,
+ }).then((data: Array<{ key: string; label: string }>) => {
+ (this.rocketTrace as any).endpoints = data;
+ this.$forceUpdate();
+ });
+ }
+ private chooseInstance(i: any) {
+ this.instance = i;
+ this.getTraceList();
}
-
private chooseStatus(i: any) {
this.traceState = i;
+ this.getTraceList();
+ }
+ private chooseEndpoint(i: any) {
+ this.endpoint = i;
+ this.getTraceList();
Review comment:
Same thing as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-821809794
Please provide screenshots about what is the latest status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822178194
> When we select a service, the logic should only fetch endpoints and instance of this service, rather than fetching services, endpoints and instance of this service, traces.
Yes, the logic should be as same as the dashboard. Only related instances and endpoints should be shown up. Keep `All` only if no service selected.
> Set a default value for endpoints name. Should we add All in endpoints selector?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r617134032
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +176,40 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
+ this.GET_ITEM_ENDPOINTS({
+ serviceId: i.key,
+ keyword: '',
+ duration: this.durationTime,
+ }).then((data: Array<{ key: string; label: string }>) => {
+ (this.rocketTrace as any).endpoints = data;
+ this.$forceUpdate();
+ });
+ }
+ private chooseInstance(i: any) {
+ this.instance = i;
+ this.getTraceList();
Review comment:
There is no need to fetch traces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-821809794
Please provide screenshots/gif/mp4 about what is the latest status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822206393
> I prefer to search traces by entering key, but I don't feel it easy to add Keyup event
I think I have said before, this is not allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-823058386
> I have checked this and have found the following problems
>
> 1. The component style of `TraceSearch` is wrong.
> 2. When we select a service, the logic should only fetch endpoints and instance of this service, rather than fetching services, endpoints and instance of this service, traces.
> 3. Set a default value for endpoints name. Should we add `All` in endpoints selector? @wu-sheng
> 
>
> Please fix those. Thank you for your contribution @horber.
Fixed, please check @Fine0830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 merged pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 merged pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822140737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822206393
> I prefer to search traces by entering key, but I don't feel it easy to add Keyup event
I think I have said before, this is not allowed. In the real product env and large-scale deployment, this will be a disaster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822235594
> > I prefer to search traces by entering key, but I don't feel it easy to add Keyup event
>
> I think I have said before, this is not allowed. In the real product env and large-scale deployment, this will be a disaster.
What I want to express is to search through the shortcut key, such as enter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822166659
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r616599212
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -132,16 +141,12 @@ limitations under the License. -->
private maxTraceDuration: string = localStorage.getItem('maxTraceDuration') || '';
private minTraceDuration: string = localStorage.getItem('minTraceDuration') || '';
private instance: Option = { label: 'All', key: '' };
- private endpointName: string = localStorage.getItem('endpointName') || '';
+ private endpoint: Option = { label: 'All', key: '' };
private traceId: string = localStorage.getItem('traceId') || '';
private traceState: Option = { label: 'All', key: 'ALL' };
private tags: string = '';
private tagsList: string[] = [];
-
private created() {
- this.endpointName = this.$route.query.endpointname
- ? this.$route.query.endpointname.toString()
- : this.endpointName;
Review comment:
After delete this, we aren't able to visit a link with endpointName, like trace id. Should we keep this? @wu-sheng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r617133260
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -132,16 +141,12 @@ limitations under the License. -->
private maxTraceDuration: string = localStorage.getItem('maxTraceDuration') || '';
private minTraceDuration: string = localStorage.getItem('minTraceDuration') || '';
private instance: Option = { label: 'All', key: '' };
- private endpointName: string = localStorage.getItem('endpointName') || '';
+ private endpoint: Option = { label: 'All', key: '' };
private traceId: string = localStorage.getItem('traceId') || '';
private traceState: Option = { label: 'All', key: 'ALL' };
private tags: string = '';
private tagsList: string[] = [];
-
private created() {
- this.endpointName = this.$route.query.endpointname
- ? this.$route.query.endpointname.toString()
- : this.endpointName;
Review comment:
Yes, the endpoint id is not required here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-822237060
I think dashboard has that for a while, please take a reference. Actually all logic should share with dashboard selector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r617134222
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -172,24 +176,40 @@ limitations under the License. -->
step,
};
}
-
private chooseService(i: any) {
if (this.service.key === i.key) {
return;
}
this.instance = { label: 'All', key: '' };
+ this.endpoint = { label: 'All', key: '' };
this.service = i;
if (i.key === '') {
this.SET_INSTANCES([]);
return;
}
this.GET_INSTANCES({ duration: this.durationTime, serviceId: i.key });
+ (this.rocketTrace as any).endpoints = [];
+ this.GET_ITEM_ENDPOINTS({
+ serviceId: i.key,
+ keyword: '',
+ duration: this.durationTime,
+ }).then((data: Array<{ key: string; label: string }>) => {
+ (this.rocketTrace as any).endpoints = data;
+ this.$forceUpdate();
+ });
+ }
+ private chooseInstance(i: any) {
+ this.instance = i;
+ this.getTraceList();
}
-
private chooseStatus(i: any) {
this.traceState = i;
+ this.getTraceList();
Review comment:
Same thing as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on a change in pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#discussion_r616702399
##########
File path: src/views/components/trace/trace-search.vue
##########
@@ -132,16 +141,12 @@ limitations under the License. -->
private maxTraceDuration: string = localStorage.getItem('maxTraceDuration') || '';
private minTraceDuration: string = localStorage.getItem('minTraceDuration') || '';
private instance: Option = { label: 'All', key: '' };
- private endpointName: string = localStorage.getItem('endpointName') || '';
+ private endpoint: Option = { label: 'All', key: '' };
private traceId: string = localStorage.getItem('traceId') || '';
private traceState: Option = { label: 'All', key: 'ALL' };
private tags: string = '';
private tagsList: string[] = [];
-
private created() {
- this.endpointName = this.$route.query.endpointname
- ? this.$route.query.endpointname.toString()
- : this.endpointName;
Review comment:
I think we only should keep `traceid` as the URI parameter for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] horber commented on pull request #474: endpoint component enhanced in trace-search
Posted by GitBox <gi...@apache.org>.
horber commented on pull request #474:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/474#issuecomment-823821115
> Style problems still exist
> 
>
> JS errors
> 
>
> Here don't need to set endpointName value in the query
> 
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org