You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/31 03:08:32 UTC

[GitHub] [shardingsphere] taojintianxia opened a new pull request #7162: Fix: fix the null table name issue

taojintianxia opened a new pull request #7162:
URL: https://github.com/apache/shardingsphere/pull/7162


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lucas-307 commented on pull request #7162: Fix: fix the null table name issue

Posted by GitBox <gi...@apache.org>.
Lucas-307 commented on pull request #7162:
URL: https://github.com/apache/shardingsphere/pull/7162#issuecomment-683620095


   @taojintianxia Hi, I rewiewed it, it's a good fix, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #7162: Fix: fix the null table name issue

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7162:
URL: https://github.com/apache/shardingsphere/pull/7162


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #7162: Fix: fix the null table name issue

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7162:
URL: https://github.com/apache/shardingsphere/pull/7162#issuecomment-683544001


   ## Pull Request Test Coverage Report for [Build 14275](https://coveralls.io/builds/33104477)
   
   * **4** of **4**   **(100.0%)**  changed or added relevant lines in **1** file are covered.
   * **4002** unchanged lines in **3** files lost coverage.
   * Overall coverage increased (+**0.01%**) to **35.634%**
   
   ---
   
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/SQLServerStatementBaseVisitor.java](https://coveralls.io/builds/33104477/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FSQLServerStatementBaseVisitor.java#L160) | 3 | 1.17% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/impl/SQLServerDMLVisitor.java](https://coveralls.io/builds/33104477/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsqlserver%2Fvisitor%2Fimpl%2FSQLServerDMLVisitor.java#L255) | 13 | 94.98% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/SQLServerStatementParser.java](https://coveralls.io/builds/33104477/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-sqlserver%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FSQLServerStatementParser.java#L719) | 3986 | 30.08% |
   <!-- | **Total:** | **4002** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/33104477/badge)](https://coveralls.io/builds/33104477) |
   | :-- | --: |
   | Change from base [Build 14268](https://coveralls.io/builds/33099503): |  0.01% |
   | Covered Lines: | 35564 |
   | Relevant Lines: | 99804 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia commented on pull request #7162: Fix: fix the null table name issue

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on pull request #7162:
URL: https://github.com/apache/shardingsphere/pull/7162#issuecomment-683526436


   @Lucas-307 hi , lu, would you please take a look on this PR ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia edited a comment on pull request #7162: Fix: fix the null table name issue

Posted by GitBox <gi...@apache.org>.
taojintianxia edited a comment on pull request #7162:
URL: https://github.com/apache/shardingsphere/pull/7162#issuecomment-683526436


   @Lucas-307 hi , lu, would you please take a look on this modification ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org