You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2018/04/19 08:39:53 UTC
[2/4] groovy git commit: Trivial refactoring: Avoid string
concatenation as argument to 'StringBuilder.append()' call
Trivial refactoring: Avoid string concatenation as argument to 'StringBuilder.append()' call
(cherry picked from commit d19ccba)
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/510699a0
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/510699a0
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/510699a0
Branch: refs/heads/GROOVY_2_6_X
Commit: 510699a0c612e7446138e51d7367cebd4221b7cc
Parents: 6ad5894
Author: sunlan <su...@apache.org>
Authored: Thu Apr 19 16:12:00 2018 +0800
Committer: sunlan <su...@apache.org>
Committed: Thu Apr 19 16:37:06 2018 +0800
----------------------------------------------------------------------
.../java/org/codehaus/groovy/classgen/AsmClassGenerator.java | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/510699a0/src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java b/src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java
index bfb70f7..476337b 100644
--- a/src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java
+++ b/src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java
@@ -435,11 +435,11 @@ public class AsmClassGenerator extends ClassGenerator {
tracer.p.print(p);
p.flush();
}
- StringBuilder outBuffer = new StringBuilder();
+ StringBuilder outBuffer = new StringBuilder(64);
outBuffer.append("ASM reporting processing error for ");
- outBuffer.append(controller.getClassNode().toString() + "#" + node.getName());
- outBuffer.append(" with signature " + node.getTypeDescriptor());
- outBuffer.append(" in " + sourceFile + ":" + node.getLineNumber());
+ outBuffer.append(controller.getClassNode().toString()).append("#").append(node.getName());
+ outBuffer.append(" with signature ").append(node.getTypeDescriptor());
+ outBuffer.append(" in ").append(sourceFile).append(":").append(node.getLineNumber());
if (writer != null) {
outBuffer.append("\nLast known generated bytecode in last generated method or constructor:\n");
outBuffer.append(writer);