You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2017/05/29 11:34:29 UTC
Review Request 59626: (PREVIEW) HDP deploy from public repo failed
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-21091
https://issues.apache.org/jira/browse/AMBARI-21091
Repository: ambari
Description
-------
We decided to select exact package version by looking through repository for target stack.
Patch preview for now.
Current patch works for stack deploy. But upgrade fails with resource_management.core.exceptions.Fail: Unable to get parameter 'version', will target that in next update
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
ambari-server/src/main/python/ambari-server.py bd86df281a
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
Diff: https://reviews.apache.org/r/59626/diff/1/
Testing
-------
Live cluster tests
Thanks,
Dmitro Lisnichenko
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On June 1, 2017, 7:21 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
> > Lines 45 (patched)
> > <https://reviews.apache.org/r/59626/diff/2/?file=1737371#file1737371line46>
> >
> > Where is this used?
return Objects.hashCode(upgradeId, clusterId, requestId, direction, suspended, upgradeType,
upgradePackage);
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176619
-----------------------------------------------------------
On June 1, 2017, 5:22 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 5:22 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176619
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
Lines 45 (patched)
<https://reviews.apache.org/r/59626/#comment249984>
Where is this used?
- Alejandro Fernandez
On June 1, 2017, 2:22 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 2:22 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On June 1, 2017, 10:23 a.m., Dmitro Lisnichenko wrote:
> >
Yeah - a result of the bulk-merging we had to do. Sometimes Eclipse picked the wrong imports I guess. Thanks for finding these!
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176612
-----------------------------------------------------------
On June 1, 2017, 10:22 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 10:22 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176612
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java
Line 44 (original)
<https://reviews.apache.org/r/59626/#comment249978>
looks like we have a trouble with imports
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
Line 82 (original), 82 (patched)
<https://reviews.apache.org/r/59626/#comment249979>
looks like we have a trouble with imports
- Dmitro Lisnichenko
On June 1, 2017, 5:22 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 5:22 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On June 1, 2017, 6:22 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/python/ambari-server.py
> > Line 800 (original)
> > <https://reviews.apache.org/r/59626/diff/1/?file=1734259#file1734259line800>
> >
> > Why is this added back? The upgrade stack option should be removed since it can't work in the world of patch/service upgrades.
it was a first revision of patch, I did not rebase it on top of commit that removes this code. Latest patch already has not that.
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176616
-----------------------------------------------------------
On June 1, 2017, 5:22 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 5:22 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176616
-----------------------------------------------------------
ambari-server/src/main/python/ambari-server.py
Line 800 (original)
<https://reviews.apache.org/r/59626/#comment249981>
Why is this added back? The upgrade stack option should be removed since it can't work in the world of patch/service upgrades.
- Jonathan Hurley
On June 1, 2017, 10:22 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 10:22 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On June 1, 2017, 9:18 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
> > Lines 121-125 (patched)
> > <https://reviews.apache.org/r/59626/diff/2/?file=1737369#file1737369line121>
> >
> > Wouldn't installed always be a subset of available? Taking CentOS as an example with ZooKeeper installed, I get this:
> >
> > ```
> > Available:
> > zookeeper.noarch 3.4.6.2.5.0.0-1237.el6 HDP-2.5-repo-1
> > zookeeper-server.noarch 3.4.6.2.5.0.0-1237.el6 HDP-2.5-repo-1
> >
> > Installed:
> > zookeeper_2_5_0_0_1237.noarch 3.4.6.2.5.0.0-1237.el6 @HDP-2.5-repo-1
> > zookeeper_2_5_0_0_1237-server.noarch 3.4.6.2.5.0.0-1237.el6 @HDP-2.5-repo-1
> > ```
> >
> > So my final list would look like:
> > zookeeper.noarch
> > zookeeper-server.noarch
> > zookeeper_2_5_0_0_1237.noarch
> > zookeeper_2_5_0_0_1237-server.noarch
> >
> > This would then return the first match. But, if I have another repo registered on here so that my list was:
> >
> > zookeeper_2_6_0_0_9999.noarch
> > zookeeper_2_6_0_0_9999-server.noarch
> > zookeeper.noarch
> > zookeeper-server.noarch
> > zookeeper_2_5_0_0_1237.noarch
> > zookeeper_2_5_0_0_1237-server.noarch
> >
> > Wouldn't it return the wrong one to install?
that is not a case for all OSs
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176640
-----------------------------------------------------------
On June 1, 2017, 5:22 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 5:22 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On June 1, 2017, 2:18 p.m., Jonathan Hurley wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
> > Lines 121-125 (patched)
> > <https://reviews.apache.org/r/59626/diff/2/?file=1737369#file1737369line121>
> >
> > Wouldn't installed always be a subset of available? Taking CentOS as an example with ZooKeeper installed, I get this:
> >
> > ```
> > Available:
> > zookeeper.noarch 3.4.6.2.5.0.0-1237.el6 HDP-2.5-repo-1
> > zookeeper-server.noarch 3.4.6.2.5.0.0-1237.el6 HDP-2.5-repo-1
> >
> > Installed:
> > zookeeper_2_5_0_0_1237.noarch 3.4.6.2.5.0.0-1237.el6 @HDP-2.5-repo-1
> > zookeeper_2_5_0_0_1237-server.noarch 3.4.6.2.5.0.0-1237.el6 @HDP-2.5-repo-1
> > ```
> >
> > So my final list would look like:
> > zookeeper.noarch
> > zookeeper-server.noarch
> > zookeeper_2_5_0_0_1237.noarch
> > zookeeper_2_5_0_0_1237-server.noarch
> >
> > This would then return the first match. But, if I have another repo registered on here so that my list was:
> >
> > zookeeper_2_6_0_0_9999.noarch
> > zookeeper_2_6_0_0_9999-server.noarch
> > zookeeper.noarch
> > zookeeper-server.noarch
> > zookeeper_2_5_0_0_1237.noarch
> > zookeeper_2_5_0_0_1237-server.noarch
> >
> > Wouldn't it return the wrong one to install?
>
> Dmitro Lisnichenko wrote:
> that is not a case for all OSs
Yes, I think that's my point - it doesn't seem to work consistenly across OS's - and if there's an expected regex match, it would pick the wrong one.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176640
-----------------------------------------------------------
On June 1, 2017, 10:22 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 10:22 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176640
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
Lines 121-125 (patched)
<https://reviews.apache.org/r/59626/#comment250009>
Wouldn't installed always be a subset of available? Taking CentOS as an example with ZooKeeper installed, I get this:
```
Available:
zookeeper.noarch 3.4.6.2.5.0.0-1237.el6 HDP-2.5-repo-1
zookeeper-server.noarch 3.4.6.2.5.0.0-1237.el6 HDP-2.5-repo-1
Installed:
zookeeper_2_5_0_0_1237.noarch 3.4.6.2.5.0.0-1237.el6 @HDP-2.5-repo-1
zookeeper_2_5_0_0_1237-server.noarch 3.4.6.2.5.0.0-1237.el6 @HDP-2.5-repo-1
```
So my final list would look like:
zookeeper.noarch
zookeeper-server.noarch
zookeeper_2_5_0_0_1237.noarch
zookeeper_2_5_0_0_1237-server.noarch
This would then return the first match. But, if I have another repo registered on here so that my list was:
zookeeper_2_6_0_0_9999.noarch
zookeeper_2_6_0_0_9999-server.noarch
zookeeper.noarch
zookeeper-server.noarch
zookeeper_2_5_0_0_1237.noarch
zookeeper_2_5_0_0_1237-server.noarch
Wouldn't it return the wrong one to install?
- Jonathan Hurley
On June 1, 2017, 10:22 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 10:22 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
> On June 1, 2017, 9:40 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
> > Lines 118-126 (patched)
> > <https://reviews.apache.org/r/59626/diff/2/?file=1737369#file1737369line118>
> >
> > Can we target package lists by using the specific repo id? I think both zypper and yum allow using ONLY a repo id. For ubuntu we may need some magic.
you are right
- Dmitro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176642
-----------------------------------------------------------
On June 7, 2017, 5:24 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 7, 2017, 5:24 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
> utility/pom.xml 7d5eb930d9
>
>
> Diff: https://reviews.apache.org/r/59626/diff/3/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176642
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
Lines 118-126 (patched)
<https://reviews.apache.org/r/59626/#comment250019>
Can we target package lists by using the specific repo id? I think both zypper and yum allow using ONLY a repo id. For ubuntu we may need some magic.
- Nate Cole
On June 1, 2017, 10:22 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 1, 2017, 10:22 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
>
>
> Diff: https://reviews.apache.org/r/59626/diff/2/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review177168
-----------------------------------------------------------
utility/pom.xml
Lines 70 (patched)
<https://reviews.apache.org/r/59626/#comment250695>
jdeb goal for utils is broken without that
- Dmitro Lisnichenko
On June 7, 2017, 5:24 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 7, 2017, 5:24 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
> utility/pom.xml 7d5eb930d9
>
>
> Diff: https://reviews.apache.org/r/59626/diff/3/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review177633
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 12, 2017, 9:38 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated June 12, 2017, 9:38 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Also other minor fixes
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestHostInfo.py a00771d471
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
> ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
> ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
> ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
> utility/pom.xml 7d5eb930d9
>
>
> Diff: https://reviews.apache.org/r/59626/diff/4/
>
>
> Testing
> -------
>
> Live cluster tests
> mvn clean test
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/
-----------------------------------------------------------
(Updated June 12, 2017, 4:38 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
List only packages from a relevant repository
Add/fix unit tests
Bugs: AMBARI-21091
https://issues.apache.org/jira/browse/AMBARI-21091
Repository: ambari
Description
-------
We decided to select exact package version by looking through repository for target stack.
Also other minor fixes
Diffs (updated)
-----
ambari-agent/src/test/python/ambari_agent/TestHostInfo.py a00771d471
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
utility/pom.xml 7d5eb930d9
Diff: https://reviews.apache.org/r/59626/diff/4/
Changes: https://reviews.apache.org/r/59626/diff/3-4/
Testing (updated)
-------
Live cluster tests
mvn clean test
Thanks,
Dmitro Lisnichenko
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/
-----------------------------------------------------------
(Updated June 7, 2017, 5:24 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
Added magic for Ubuntu.
Need more magic for Suse (also, ambari-setup for Suse seems to be broken)
Bugs: AMBARI-21091
https://issues.apache.org/jira/browse/AMBARI-21091
Repository: ambari
Description
-------
We decided to select exact package version by looking through repository for target stack.
Also other minor fixes
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
utility/pom.xml 7d5eb930d9
Diff: https://reviews.apache.org/r/59626/diff/3/
Changes: https://reviews.apache.org/r/59626/diff/2-3/
Testing
-------
Live cluster tests
Thanks,
Dmitro Lisnichenko
Re: Review Request 59626: HDP deploy from public repo failed
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/
-----------------------------------------------------------
(Updated June 1, 2017, 5:22 p.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Changes
-------
addressed commands, more fixes
Summary (updated)
-----------------
HDP deploy from public repo failed
Bugs: AMBARI-21091
https://issues.apache.org/jira/browse/AMBARI-21091
Repository: ambari
Description (updated)
-------
We decided to select exact package version by looking through repository for target stack.
Also other minor fixes
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java 975d6a63d8
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeHistoryEntity.java 8bfafd34bf
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java 35fffda001
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 5f5576e3e7
ambari-server/src/test/python/custom_actions/configs/install_packages_config.json c6575b51a7
ambari-server/src/test/python/stacks/2.0.6/HBASE/test_hbase_master.py fda63e099a
ambari-server/src/test/python/stacks/2.0.6/configs/hbase_with_phx.json 51476031d8
Diff: https://reviews.apache.org/r/59626/diff/2/
Changes: https://reviews.apache.org/r/59626/diff/1-2/
Testing
-------
Live cluster tests
Thanks,
Dmitro Lisnichenko
Re: Review Request 59626: (PREVIEW) HDP deploy from public repo failed
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176302
-----------------------------------------------------------
So far so good, will check again when there's an update for the version error.
- Nate Cole
On May 29, 2017, 7:34 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 7:34 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Patch preview for now.
> Current patch works for stack deploy. But upgrade fails with resource_management.core.exceptions.Fail: Unable to get parameter 'version', will target that in next update
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/python/ambari-server.py bd86df281a
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
>
>
> Diff: https://reviews.apache.org/r/59626/diff/1/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>
Re: Review Request 59626: (PREVIEW) HDP deploy from public repo failed
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59626/#review176355
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py
Lines 112-120 (patched)
<https://reviews.apache.org/r/59626/#comment249745>
Is this iterating over RepoVersionEntity IDs? How would those match with the packages coming back from allAvailablePackages. I guess I'm a bit confused by what this is really doing.
Maybe some documenatation is needed to clarify what's actually happening.
- Jonathan Hurley
On May 29, 2017, 7:34 a.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59626/
> -----------------------------------------------------------
>
> (Updated May 29, 2017, 7:34 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-21091
> https://issues.apache.org/jira/browse/AMBARI-21091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We decided to select exact package version by looking through repository for target stack.
> Patch preview for now.
> Current patch works for stack deploy. But upgrade fails with resource_management.core.exceptions.Fail: Unable to get parameter 'version', will target that in next update
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/packages_analyzer.py 8a15ee5ec5
> ambari-common/src/main/python/resource_management/libraries/script/script.py 054490b03e
> ambari-server/src/main/python/ambari-server.py bd86df281a
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py c12dff16b1
>
>
> Diff: https://reviews.apache.org/r/59626/diff/1/
>
>
> Testing
> -------
>
> Live cluster tests
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>