You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (Created) (JIRA)" <ji...@apache.org> on 2012/04/10 18:49:13 UTC

[jira] [Created] (HBASE-5759) HBaseClient throws NullPointerException when EOFException should be used.

HBaseClient throws NullPointerException when EOFException should be used.
-------------------------------------------------------------------------

                 Key: HBASE-5759
                 URL: https://issues.apache.org/jira/browse/HBASE-5759
             Project: HBase
          Issue Type: Bug
            Reporter: Jimmy Xiang
            Assignee: Jimmy Xiang
            Priority: Trivial
         Attachments: hbase-5759.patch

When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.

We need to check if the response is null before trying to access it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5759) HBaseClient throws NullPointerException when EOFException should be used.

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250859#comment-13250859 ] 

Hadoop QA commented on HBASE-5759:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12522127/hbase-5759.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1464//console

This message is automatically generated.
                
> HBaseClient throws NullPointerException when EOFException should be used.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5759
>                 URL: https://issues.apache.org/jira/browse/HBASE-5759
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>         Attachments: hbase-5759.patch
>
>
> When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.
> We need to check if the response is null before trying to access it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5759) HBaseClient throws NullPointerException when EOFException should be used.

Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-5759:
-------------------------------

    Attachment: hbase-5759.patch
    
> HBaseClient throws NullPointerException when EOFException should be used.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5759
>                 URL: https://issues.apache.org/jira/browse/HBASE-5759
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>         Attachments: hbase-5759.patch
>
>
> When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.
> We need to check if the response is null before trying to access it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5759) HBaseClient throws NullPointerException when EOFException should be used.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251360#comment-13251360 ] 

Hudson commented on HBASE-5759:
-------------------------------

Integrated in HBase-TRUNK-security #167 (See [https://builds.apache.org/job/HBase-TRUNK-security/167/])
    HBASE-5759 HBaseClient throws NullPointerException when EOFException should be used. (Revision 1311899)

     Result = SUCCESS
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java

                
> HBaseClient throws NullPointerException when EOFException should be used.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5759
>                 URL: https://issues.apache.org/jira/browse/HBASE-5759
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>             Fix For: 0.96.0
>
>         Attachments: hbase-5759.patch
>
>
> When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.
> We need to check if the response is null before trying to access it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5759) HBaseClient throws NullPointerException when EOFException should be used.

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251097#comment-13251097 ] 

Hudson commented on HBASE-5759:
-------------------------------

Integrated in HBase-TRUNK #2738 (See [https://builds.apache.org/job/HBase-TRUNK/2738/])
    HBASE-5759 HBaseClient throws NullPointerException when EOFException should be used. (Revision 1311899)

     Result = SUCCESS
stack : 
Files : 
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java

                
> HBaseClient throws NullPointerException when EOFException should be used.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5759
>                 URL: https://issues.apache.org/jira/browse/HBASE-5759
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>             Fix For: 0.96.0
>
>         Attachments: hbase-5759.patch
>
>
> When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.
> We need to check if the response is null before trying to access it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5759) HBaseClient throws NullPointerException when EOFException should be used.

Posted by "Jimmy Xiang (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy Xiang updated HBASE-5759:
-------------------------------

    Status: Patch Available  (was: Open)

There is a trailing space. Please remove it before commit it. Thanks.
                
> HBaseClient throws NullPointerException when EOFException should be used.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5759
>                 URL: https://issues.apache.org/jira/browse/HBASE-5759
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>         Attachments: hbase-5759.patch
>
>
> When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.
> We need to check if the response is null before trying to access it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-5759) HBaseClient throws NullPointerException when EOFException should be used.

Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250817#comment-13250817 ] 

Zhihong Yu commented on HBASE-5759:
-----------------------------------

Patch makes sense.
                
> HBaseClient throws NullPointerException when EOFException should be used.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5759
>                 URL: https://issues.apache.org/jira/browse/HBASE-5759
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>         Attachments: hbase-5759.patch
>
>
> When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.
> We need to check if the response is null before trying to access it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-5759) HBaseClient throws NullPointerException when EOFException should be used.

Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-5759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-5759:
-------------------------

       Resolution: Fixed
    Fix Version/s: 0.96.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks for the patch Jimmy
                
> HBaseClient throws NullPointerException when EOFException should be used.
> -------------------------------------------------------------------------
>
>                 Key: HBASE-5759
>                 URL: https://issues.apache.org/jira/browse/HBASE-5759
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Trivial
>             Fix For: 0.96.0
>
>         Attachments: hbase-5759.patch
>
>
> When a RPC data input stream is closed, protobuf doesn't raise an EOFException, it returns a null RpcResponse object.
> We need to check if the response is null before trying to access it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira