You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/02/04 13:31:47 UTC

[GitHub] [incubator-yunikorn-k8shim] pbacsko opened a new pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

pbacsko opened a new pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362


   ### What is this PR for?
   Add more cluster-wide metrics to Yunikorn.
   We're exposing the "Ready" condition from the shim side on node addition/update. 
   https://kubernetes.io/docs/concepts/architecture/nodes/#condition
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [x] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#discussion_r813533181



##########
File path: pkg/cache/nodes.go
##########
@@ -212,6 +213,15 @@ func (nc *schedulerNodes) updateNode(oldNode, newNode *v1.Node) {
 		return
 	}
 
+	if schedulerNode, ok := nc.nodesMap[newNode.Name]; ok {
+		schedulerNode.ready = common.HasReadyCondition(newNode)

Review comment:
       I filed YUNIKORN-1091 for the broken nodesMap update.
   We do need this update in the node. This change will clash with that fix.
   I also logged YUNIKORN-1090 to remove the common.Node object. That change is impacted by what we have here too.
   Moving forward and leaving the fix up for the two new jiras.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#discussion_r813533391



##########
File path: pkg/cache/nodes.go
##########
@@ -212,6 +213,15 @@ func (nc *schedulerNodes) updateNode(oldNode, newNode *v1.Node) {
 		return
 	}
 
+	if schedulerNode, ok := nc.nodesMap[newNode.Name]; ok {
+		schedulerNode.ready = common.HasReadyCondition(newNode)

Review comment:
       I filed YUNIKORN-1091 for the broken nodesMap update.
   We do need this update in the node. This change will clash with that fix.
   I also logged YUNIKORN-1090 to remove the common.Node object. That change is impacted by what we have here too.
   Moving forward and leaving the fix up for the two new jiras.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#discussion_r811566198



##########
File path: pkg/cache/nodes.go
##########
@@ -212,6 +213,15 @@ func (nc *schedulerNodes) updateNode(oldNode, newNode *v1.Node) {
 		return
 	}
 
+	if schedulerNode, ok := nc.nodesMap[newNode.Name]; ok {
+		schedulerNode.ready = common.HasReadyCondition(newNode)

Review comment:
       The `nodesMap` looks broken. I think we have a bigger issue in this code.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#issuecomment-1029995747


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#362](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ed528e) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/0bdc1bf25e6a18f0be961d75c75c5dd7c58ca00d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bdc1bf) will **decrease** coverage by `0.03%`.
   > The diff coverage is `52.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #362      +/-   ##
   ==========================================
   - Coverage   62.41%   62.38%   -0.04%     
   ==========================================
     Files          41       41              
     Lines        6152     6173      +21     
   ==========================================
   + Hits         3840     3851      +11     
   - Misses       2160     2169       +9     
   - Partials      152      153       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `62.98% <0.00%> (-0.83%)` | :arrow_down: |
   | [pkg/common/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9ub2RlLmdv) | `71.42% <37.50%> (-14.29%)` | :arrow_down: |
   | [pkg/cache/nodes.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVzLmdv) | `77.16% <63.63%> (-1.13%)` | :arrow_down: |
   | [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `86.56% <100.00%> (+0.13%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bdc1bf...1ed528e](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#issuecomment-1029995747


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#362](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e0a1ff8) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/0bdc1bf25e6a18f0be961d75c75c5dd7c58ca00d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bdc1bf) will **increase** coverage by `1.97%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #362      +/-   ##
   ==========================================
   + Coverage   62.41%   64.39%   +1.97%     
   ==========================================
     Files          41       41              
     Lines        6152     6165      +13     
   ==========================================
   + Hits         3840     3970     +130     
   + Misses       2160     2041     -119     
   - Partials      152      154       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `62.98% <0.00%> (-0.83%)` | :arrow_down: |
   | [pkg/common/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9ub2RlLmdv) | `71.42% <37.50%> (-14.29%)` | :arrow_down: |
   | [pkg/cache/nodes.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVzLmdv) | `77.16% <63.63%> (-1.13%)` | :arrow_down: |
   | [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `86.56% <100.00%> (+0.13%)` | :arrow_up: |
   | [pkg/cache/node\_coordinator.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVfY29vcmRpbmF0b3IuZ28=) | `66.21% <0.00%> (+2.92%)` | :arrow_up: |
   | [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `41.56% <0.00%> (+6.86%)` | :arrow_up: |
   | [pkg/cache/external/scheduler\_cache.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2V4dGVybmFsL3NjaGVkdWxlcl9jYWNoZS5nbw==) | `58.55% <0.00%> (+27.63%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bdc1bf...e0a1ff8](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] pbacsko commented on a change in pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
pbacsko commented on a change in pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#discussion_r799467872



##########
File path: pkg/common/si_helper.go
##########
@@ -159,7 +160,9 @@ func CreateUpdateRequestForUpdatedNode(node Node) si.NodeRequest {
 	// Currently only includes resource in the update request
 	nodeInfo := &si.NodeInfo{
 		NodeID:              node.name,
-		Attributes:          make(map[string]string),
+		Attributes:          map[string]string {
+			"ready":		 strconv.FormatBool(node.ready),

Review comment:
       Temporary solution. Either should be in `NodeInfo` or define a constant for it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] pbacsko commented on a change in pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
pbacsko commented on a change in pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#discussion_r799473141



##########
File path: pkg/cache/nodes.go
##########
@@ -212,6 +213,15 @@ func (nc *schedulerNodes) updateNode(oldNode, newNode *v1.Node) {
 		return
 	}
 
+	if schedulerNode, ok := nc.nodesMap[newNode.Name]; ok {
+		schedulerNode.ready = common.HasReadyCondition(newNode)

Review comment:
       Updating this field in `SchedulerNode` is probably not necessary, but for the sake of consistency, I decided to do it anyway.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #362: [YUNIKORN-1052] Add more cluster-wide metrics to Yunikorn

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #362:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/362#issuecomment-1029995747


   # [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#362](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ed528e) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/0bdc1bf25e6a18f0be961d75c75c5dd7c58ca00d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0bdc1bf) will **decrease** coverage by `0.03%`.
   > The diff coverage is `52.00%`.
   
   > :exclamation: Current head 1ed528e differs from pull request most recent head e0a1ff8. Consider uploading reports for the commit e0a1ff8 to get more accurate results
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/graphs/tree.svg?width=650&height=150&src=pr&token=LZImIuvleR&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #362      +/-   ##
   ==========================================
   - Coverage   62.41%   62.38%   -0.04%     
   ==========================================
     Files          41       41              
     Lines        6152     6173      +21     
   ==========================================
   + Hits         3840     3851      +11     
   - Misses       2160     2169       +9     
   - Partials      152      153       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/common/si\_helper.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `62.98% <0.00%> (-0.83%)` | :arrow_down: |
   | [pkg/common/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9ub2RlLmdv) | `71.42% <37.50%> (-14.29%)` | :arrow_down: |
   | [pkg/cache/nodes.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVzLmdv) | `77.16% <63.63%> (-1.13%)` | :arrow_down: |
   | [pkg/cache/node.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `86.56% <100.00%> (+0.13%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0bdc1bf...e0a1ff8](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/362?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org