[GitHub] [camel-k-runtime] valdar commented on a change in pull request #26: Fixed version checking in Catalog to accomodate also x.y.z-something …

[GitBox <gi...@apache.org>]

valdar commented on a change in pull request #26: Fixed version checking in Catalog to accomodate also x.y.z-something …
URL: https://github.com/apache/camel-k-runtime/pull/26#discussion_r262536521
 
 

 ##########
 File path: camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/processors/CatalogProcessor_2_x.java
 ##########
 @@ -76,7 +76,8 @@ public int getOrder() {
 
     @Override
     public boolean accepts(CamelCatalog catalog) {
-        return new Semver(catalog.getCatalogVersion(), Semver.SemverType.IVY).satisfies("[2.18,3]");
+        Semver semver = new Semver(catalog.getCatalogVersion(), Semver.SemverType.IVY);
+        return semver.isGreaterThanOrEqualTo("2.18.0") && semver.isLowerThan("4.0.0");
 
 Review comment:
   is LowerThan not LowerOrEqual, check the tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services