You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by jo...@apache.org on 2014/12/10 08:47:23 UTC
spark git commit: [Minor] Use tag for help icon in web UI page
header
Repository: spark
Updated Branches:
refs/heads/master 9bd9334f5 -> f79c1cfc9
[Minor] Use <sup> tag for help icon in web UI page header
This small commit makes the `(?)` web UI help link into a superscript, which should address feedback that the current design makes it look like an error occurred or like information is missing.
Before:
![image](https://cloud.githubusercontent.com/assets/50748/5370611/a3ed0034-7fd9-11e4-870f-05bd9faad5b9.png)
After:
![image](https://cloud.githubusercontent.com/assets/50748/5370602/6c5ca8d6-7fd9-11e4-8d1a-568d71290aa7.png)
Author: Josh Rosen <jo...@databricks.com>
Closes #3659 from JoshRosen/webui-help-sup and squashes the following commits:
bd72899 [Josh Rosen] Use <sup> tag for help icon in web UI page header.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f79c1cfc
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f79c1cfc
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f79c1cfc
Branch: refs/heads/master
Commit: f79c1cfc997c1a7ddee480ca3d46f5341b69d3b7
Parents: 9bd9334
Author: Josh Rosen <jo...@databricks.com>
Authored: Tue Dec 9 23:47:05 2014 -0800
Committer: Josh Rosen <jo...@databricks.com>
Committed: Tue Dec 9 23:47:05 2014 -0800
----------------------------------------------------------------------
core/src/main/scala/org/apache/spark/ui/UIUtils.scala | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/f79c1cfc/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/UIUtils.scala b/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
index 315327c..d970fa3 100644
--- a/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
+++ b/core/src/main/scala/org/apache/spark/ui/UIUtils.scala
@@ -181,7 +181,9 @@ private[spark] object UIUtils extends Logging {
</li>
}
val helpButton: Seq[Node] = helpText.map { helpText =>
- <a data-toggle="tooltip" data-placement="bottom" title={helpText}>(?)</a>
+ <sup>
+ (<a data-toggle="tooltip" data-placement="bottom" title={helpText}>?</a>)
+ </sup>
}.getOrElse(Seq.empty)
<html>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org