You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/01/18 11:55:43 UTC

[jira] Updated: (WICKET-3347) Simplify somehow the code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle)

     [ https://issues.apache.org/jira/browse/WICKET-3347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-3347:
------------------------------------

    Description: 
The code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle) decides whether to redirect or directly render the current page depending on several conditions:
 - is Ajax request
 - the redirect policy (org.apache.wicket.request.handler.RenderPageRequestHandler.RedirectPolicy)
 - the render strategy (org.apache.wicket.settings.IRequestCycleSettings.RenderStrategy)
 - whether the page is stateless

All these conditions lead to complex and fragile code.

We have to think how to improve this.

  was:
The code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle) decides whether to redirect or directly render the current page depending on several conditions:
 - is Ajax request
 - the redirect policy (org.apache.wicket.request.handler.RenderPageRequestHandler.RedirectPolicy)
 - the render strategy (org.apache.wicket.settings.IRequestCycleSettings.RenderStrategy)
 - whether the page is stateless
 - whether this is page interception (see WICKET-3339)

All these conditions lead to complex and fragile code.

We have to think how to improve this.


> Simplify somehow the code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle)
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3347
>                 URL: https://issues.apache.org/jira/browse/WICKET-3347
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Martin Grigorov
>
> The code in org.apache.wicket.request.handler.render.WebPageRenderer.respond(RequestCycle) decides whether to redirect or directly render the current page depending on several conditions:
>  - is Ajax request
>  - the redirect policy (org.apache.wicket.request.handler.RenderPageRequestHandler.RedirectPolicy)
>  - the render strategy (org.apache.wicket.settings.IRequestCycleSettings.RenderStrategy)
>  - whether the page is stateless
> All these conditions lead to complex and fragile code.
> We have to think how to improve this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.