You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metron.apache.org by Otto Fowler <ot...@gmail.com> on 2017/05/03 12:25:21 UTC
[DISCUSS] platform_info.sh and PR template / Dev Guidelines
I think we should have documented in the template and guidelines something
to the extent ( appropriate for the document ) of :
“Metron provides a platform_info.sh script in metron-deployment/scripts
that outputs information that may be important to troubleshooting build and
deployment issues. It is important if any development introduces new
technology to the stack that effects the build and deployment by it’s
presence or version, that the platform_info.sh be updated to reflect that
information.”
pr:
[ ] platform_info.sh updated for new dependencies
Re: [DISCUSS] platform_info.sh and PR template / Dev Guidelines
Posted by Michael Miklavcic <mi...@gmail.com>.
I agree with Nick about the PR template insofar as we should keep it
simple. And for any checklist items, we should seek to automate as much as
possible. We've already made some strides with Justin Leet's changes to
include site-book building in the main build, for instance. I'd prefer to
add this to developer guidelines on the wiki or a general dev README in the
project.
On Wed, May 3, 2017 at 7:26 AM, Nick Allen <ni...@nickallen.org> wrote:
> +0 I am not a fan of the PR template. In my opinion, there is too much
> text already and I ended up just skipping over it. I think it gets in the
> way of a contributor actually describing their change. Just my opinion. I
> know many others disagree and find value in it.
>
> On Wed, May 3, 2017 at 8:27 AM, Otto Fowler <ot...@gmail.com>
> wrote:
>
> > For example: we have recently introduced dependencies on Docker, Node.js
> > and NPM that needed to be added later.
> >
> >
> > On May 3, 2017 at 08:25:21, Otto Fowler (ottobackwards@gmail.com) wrote:
> >
> > I think we should have documented in the template and guidelines
> something
> > to the extent ( appropriate for the document ) of :
> >
> > “Metron provides a platform_info.sh script in metron-deployment/scripts
> > that outputs information that may be important to troubleshooting build
> and
> > deployment issues. It is important if any development introduces new
> > technology to the stack that effects the build and deployment by it’s
> > presence or version, that the platform_info.sh be updated to reflect that
> > information.”
> >
> >
> > pr:
> > [ ] platform_info.sh updated for new dependencies
> >
>
Re: [DISCUSS] platform_info.sh and PR template / Dev Guidelines
Posted by Nick Allen <ni...@nickallen.org>.
+0 I am not a fan of the PR template. In my opinion, there is too much
text already and I ended up just skipping over it. I think it gets in the
way of a contributor actually describing their change. Just my opinion. I
know many others disagree and find value in it.
On Wed, May 3, 2017 at 8:27 AM, Otto Fowler <ot...@gmail.com> wrote:
> For example: we have recently introduced dependencies on Docker, Node.js
> and NPM that needed to be added later.
>
>
> On May 3, 2017 at 08:25:21, Otto Fowler (ottobackwards@gmail.com) wrote:
>
> I think we should have documented in the template and guidelines something
> to the extent ( appropriate for the document ) of :
>
> “Metron provides a platform_info.sh script in metron-deployment/scripts
> that outputs information that may be important to troubleshooting build and
> deployment issues. It is important if any development introduces new
> technology to the stack that effects the build and deployment by it’s
> presence or version, that the platform_info.sh be updated to reflect that
> information.”
>
>
> pr:
> [ ] platform_info.sh updated for new dependencies
>
Re: [DISCUSS] platform_info.sh and PR template / Dev Guidelines
Posted by Otto Fowler <ot...@gmail.com>.
For example: we have recently introduced dependencies on Docker, Node.js
and NPM that needed to be added later.
On May 3, 2017 at 08:25:21, Otto Fowler (ottobackwards@gmail.com) wrote:
I think we should have documented in the template and guidelines something
to the extent ( appropriate for the document ) of :
“Metron provides a platform_info.sh script in metron-deployment/scripts
that outputs information that may be important to troubleshooting build and
deployment issues. It is important if any development introduces new
technology to the stack that effects the build and deployment by it’s
presence or version, that the platform_info.sh be updated to reflect that
information.”
pr:
[ ] platform_info.sh updated for new dependencies