[jira] [Commented] (ROL-2073) Move hard-coded date / timestamp formatting to ApplicationResources

["Glen Mazza (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROL-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524384#comment-14524384 ] 

Glen Mazza commented on ROL-2073:
---------------------------------

Hi Kohei, thanks for investigating this.  Yes, it would be nice to move the date formatters into the application.properties but probably not the words around it as people frequently change the "Posted by .... at .... in category ...." sentence anyway to get it appearing as they like and by keeping the words away, date-only formatters in the app.properties can be used in more places.  I don't think we have to go overboard though on minor things because we do allow templates to be modified by the blogger.

> Move hard-coded date / timestamp formatting to ApplicationResources
> -------------------------------------------------------------------
>
>                 Key: ROL-2073
>                 URL: https://issues.apache.org/jira/browse/ROL-2073
>             Project: Apache Roller
>          Issue Type: Improvement
>          Components: Themes and Macros
>    Affects Versions: 5.1.2
>            Reporter: Kohei Nozaki
>            Assignee: Roller Unassigned
>            Priority: Trivial
>         Attachments: ROL-2073.patch
>
>
> There're some hard-coded date / timestamp formatting as follows:
> In {{_day.vm}} or {{day.vm}} of templates:
> {noformat}
> $utils.formatDate($day, "EEEE MMM dd, yyyy")
> $utils.formatDate($entry.pubTime, "hh:mma MMM dd, yyyy")
> {noformat}
> In {{CalendarTag#doStartTag()}}:
> {noformat}
> // formatter Month-Year title of calendar
> SimpleDateFormat formatTitle = new SimpleDateFormat("MMMM yyyy", mLocale);
> {noformat}
> In Japanese locale, it produces following expressions:
> # 水曜日 4 22, 2015
> # Posted at 02:15午後 4 22, 2015 by kyle in Technology  |  投稿されたコメント [0]
> # 4月 2015
> They looks pretty weird to Japanese people. I think Japanese people prefer following expressions instead:
> # 2015年4月22日 (水)
> # Posted at 2015年4月22日 午後 02:15 (this may better to move the fragment entirely, not only the date, but it might be too much for default templates)
> # 2015年4月
> And I think these strange expressions may effect badly to first impression of Japanese people who just installed Roller so give it a try. so I'd like to move these expressions to ApplicationResources so that allow templates to show locale specific expressions. any thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)