You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/12/20 03:37:36 UTC
Review Request 54880: Added unit-test for dynamic addition/deletion
of CNI config.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54880/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-6567
https://issues.apache.org/jira/browse/MESOS-6567
Repository: mesos
Description
-------
Added unit-test for dynamic addition/deletion of CNI config.
Diffs
-----
src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72
Diff: https://reviews.apache.org/r/54880/diff/
Testing
-------
sudo ./bin/mesos-tests.sh --gtest_filter=*Cni*
Thanks,
Avinash sridharan
Re: Review Request 54880: Added unit-test for dynamic
addition/deletion of CNI config.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54880/#review159739
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54716, 54717, 54718, 54880]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 20, 2016, 3:37 a.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54880/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 3:37 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-6567
> https://issues.apache.org/jira/browse/MESOS-6567
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit-test for dynamic addition/deletion of CNI config.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72
>
> Diff: https://reviews.apache.org/r/54880/diff/
>
>
> Testing
> -------
>
> sudo ./bin/mesos-tests.sh --gtest_filter=*Cni*
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 54880: Added unit-test for dynamic
addition/deletion of CNI config.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54880/#review159826
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54716, 54717, 54718, 54880]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 20, 2016, 10:36 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54880/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 10:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-6567
> https://issues.apache.org/jira/browse/MESOS-6567
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit-test for dynamic addition/deletion of CNI config.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72
>
> Diff: https://reviews.apache.org/r/54880/diff/
>
>
> Testing
> -------
>
> sudo ./bin/mesos-tests.sh --gtest_filter=*Cni*
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 54880: Added unit-test for dynamic
addition/deletion of CNI config.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54880/#review159874
-----------------------------------------------------------
Fix it, then Ship it!
This test takes a long time to finish. Mainly because the filters are not set properly, as well as the clocks are not advanced properly. I did quite a few changes while committing. Please take a look.
src/tests/containerizer/cni_isolator_tests.cpp (line 702)
<https://reviews.apache.org/r/54880/#comment230931>
Remove the extra space
- Jie Yu
On Dec. 20, 2016, 10:36 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54880/
> -----------------------------------------------------------
>
> (Updated Dec. 20, 2016, 10:36 p.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-6567
> https://issues.apache.org/jira/browse/MESOS-6567
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit-test for dynamic addition/deletion of CNI config.
>
>
> Diffs
> -----
>
> src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72
>
> Diff: https://reviews.apache.org/r/54880/diff/
>
>
> Testing
> -------
>
> sudo ./bin/mesos-tests.sh --gtest_filter=*Cni*
>
>
> Thanks,
>
> Avinash sridharan
>
>
Re: Review Request 54880: Added unit-test for dynamic
addition/deletion of CNI config.
Posted by Avinash sridharan <av...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54880/
-----------------------------------------------------------
(Updated Dec. 20, 2016, 10:36 p.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Changes
-------
Fixed some typos in comments.
Bugs: MESOS-6567
https://issues.apache.org/jira/browse/MESOS-6567
Repository: mesos
Description
-------
Added unit-test for dynamic addition/deletion of CNI config.
Diffs (updated)
-----
src/tests/containerizer/cni_isolator_tests.cpp 0380f2ca122c7b8ab1dac351b14f546526580e72
Diff: https://reviews.apache.org/r/54880/diff/
Testing
-------
sudo ./bin/mesos-tests.sh --gtest_filter=*Cni*
Thanks,
Avinash sridharan