[GitHub] [pinot] walterddr commented on a change in pull request #8162: Disable recursion in PinotFS copy

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #8162:
URL: https://github.com/apache/pinot/pull/8162#discussion_r803927648



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/LocalPinotFS.java
##########
@@ -85,7 +85,7 @@ public boolean doMove(URI srcUri, URI dstUri)
   @Override
   public boolean copy(URI srcUri, URI dstUri)
       throws IOException {
-    copy(toFile(srcUri), toFile(dstUri));
+    copy(toFile(srcUri), toFile(dstUri), false);

Review comment:
       the behavior of this API is not the same in LocalPinotFs vs. S3PinotFs. 
   
   should we also expose a `copy(URI srcUri, URI dstUri, boolean isRecursive)`  ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org