You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2016/07/28 14:59:28 UTC

[GitHub] activemq-artemis pull request #677: ARTEMIS-565 additional JSON fixes

Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/677#discussion_r72638984
  
    --- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java ---
    @@ -295,6 +295,13 @@ else if (jsonValue == JsonValue.FALSE) {
                 return jsonValue.toString();
              }
           }
    +      else if (jsonValue instanceof Object[]) {
    +         Object[] array = (Object[]) jsonValue;
    +         for (int i = 0; i < array.length; i++) {
    +            array[i] = convertJsonValue(array[i], desiredType);
    --- End diff --
    
    Yes, I added this because of a real failure.  The method wouldn't handle Object[] before this so would fail for management methods that returned, e.g. String[].


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---