You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/01/25 02:15:05 UTC

[GitHub] [activemq-nms-amqp] tye-star commented on a change in pull request #41: AMQNET-605: Pre-buffered messages shouldn't be released when consumer closes down

tye-star commented on a change in pull request #41:
URL: https://github.com/apache/activemq-nms-amqp/pull/41#discussion_r563428331



##########
File path: test/Apache-NMS-AMQP-Test/Integration/ConsumerIntegrationTest.cs
##########
@@ -232,67 +232,6 @@ public void TestCloseDurableTopicSubscriberDetachesWithCloseFalse()
             }
         }
 
-        // TODO: To be fixed
-        [Test, Timeout(20_000), Ignore("Ignore")]
-        public void TestCloseDurableSubscriberWithUnackedAndUnconsumedPrefetchedMessages()
-        {
-            using (TestAmqpPeer testPeer = new TestAmqpPeer())
-            {
-                IConnection connection = EstablishConnection(testPeer);
-                connection.Start();
-
-                testPeer.ExpectBegin();
-
-                ISession session = connection.CreateSession(AcknowledgementMode.AutoAcknowledge);
-
-                string topicName = "myTopic";
-                string subscriptionName = "mySubscription";
-                ITopic topic = session.GetTopic(topicName);
-
-                int messageCount = 5;
-                // Create a consumer and fill the prefetch with some messages,

Review comment:
        testPeer.ExpectBegin();




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org