You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Cpaulyz (via GitHub)" <gi...@apache.org> on 2023/11/27 11:46:53 UTC
[PR] Fix query return unexpected result with authority [iotdb]
Cpaulyz opened a new pull request, #11626:
URL: https://github.com/apache/iotdb/pull/11626
## Description
This PR fix some query bugs with authority:
1. Query pure template series with partitial authority.
<img width="962" alt="image" src="https://github.com/apache/iotdb/assets/43774645/baef6ef2-f862-400d-8b4c-32d776f187e3">
<img width="678" alt="image" src="https://github.com/apache/iotdb/assets/43774645/d3b076cf-0842-4556-8580-3dbea0369a8d">
2. Query view series without origin time series read authority.
<img width="966" alt="image" src="https://github.com/apache/iotdb/assets/43774645/d28178e2-27b9-4cd6-97ef-d05574fed82d">
<img width="798" alt="image" src="https://github.com/apache/iotdb/assets/43774645/f80d017c-84b8-4366-9e1a-677e42e2affc">
For implementation, I removed the authorityScope field from the ClusterSchemaTree for better maintenance. To avoid redundant measurement when ClusterSchemaTree uses templates, the query engine will determine whether to fetch schema with template by `authorityScope`.
```java
// If the authority scope of query statement contains full path, we should fetch schema
// without template. Otherwise, the result ISchemaTree may contain template series that is
// not authorized to access.
boolean allWildcardLeaf = !authorizedPatternTree.isContainFullPath() && authorizedPatternTree.isContainWildcard();
```
If allWildcardLeaf is true, the result ClusterSchemaTree must not contain redundant measurement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix query return unexpected result with authority [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #11626:
URL: https://github.com/apache/iotdb/pull/11626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org