You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/11/30 00:35:09 UTC
[kudu-CR] [tools] disambiguate parse metrics' output
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20741
Change subject: [tools] disambiguate parse_metrics' output
......................................................................
[tools] disambiguate parse_metrics' output
This patch improves the output of the 'kudu diagnostic parse_metrics'
CLI tool. Prior to this patch, it was impossible to tell between
absent metric values at a particular timestamp and zeros. With this
patch, an absent value and undefined rate of change of a metric for
a particular timestamp are indicated with the '?' ASCII character.
Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
---
M src/kudu/tools/diagnostics_log_parser.cc
M src/kudu/tools/diagnostics_log_parser.h
2 files changed, 67 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20741/1
--
To view, visit http://gerrit.cloudera.org:8080/20741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tools] disambiguate parse metrics' output
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20741 )
Change subject: [tools] disambiguate parse_metrics' output
......................................................................
[tools] disambiguate parse_metrics' output
This patch improves the output of the 'kudu diagnostic parse_metrics'
CLI tool. Prior to this patch, it was impossible to tell between
absent metric values at a particular timestamp and zeros. With this
patch, an absent value and undefined rate of change of a metric for
a particular timestamp are indicated with the '?' ASCII character.
Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
Reviewed-on: http://gerrit.cloudera.org:8080/20741
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/tools/diagnostics_log_parser.cc
M src/kudu/tools/diagnostics_log_parser.h
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 80 insertions(+), 46 deletions(-)
Approvals:
Kudu Jenkins: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] disambiguate parse metrics' output
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20741 )
Change subject: [tools] disambiguate parse_metrics' output
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Dec 2023 17:57:17 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] disambiguate parse metrics' output
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20741
to look at the new patch set (#2).
Change subject: [tools] disambiguate parse_metrics' output
......................................................................
[tools] disambiguate parse_metrics' output
This patch improves the output of the 'kudu diagnostic parse_metrics'
CLI tool. Prior to this patch, it was impossible to tell between
absent metric values at a particular timestamp and zeros. With this
patch, an absent value and undefined rate of change of a metric for
a particular timestamp are indicated with the '?' ASCII character.
Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
---
M src/kudu/tools/diagnostics_log_parser.cc
M src/kudu/tools/diagnostics_log_parser.h
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 80 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20741/2
--
To view, visit http://gerrit.cloudera.org:8080/20741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] disambiguate parse metrics' output
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20741 )
Change subject: [tools] disambiguate parse_metrics' output
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20741/2/src/kudu/tools/diagnostics_log_parser.h
File src/kudu/tools/diagnostics_log_parser.h:
http://gerrit.cloudera.org:8080/#/c/20741/2/src/kudu/tools/diagnostics_log_parser.h@216
PS2, Line 216: signle
nit: single
--
To view, visit http://gerrit.cloudera.org:8080/20741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Dec 2023 03:00:00 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] disambiguate parse metrics' output
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20741
to look at the new patch set (#3).
Change subject: [tools] disambiguate parse_metrics' output
......................................................................
[tools] disambiguate parse_metrics' output
This patch improves the output of the 'kudu diagnostic parse_metrics'
CLI tool. Prior to this patch, it was impossible to tell between
absent metric values at a particular timestamp and zeros. With this
patch, an absent value and undefined rate of change of a metric for
a particular timestamp are indicated with the '?' ASCII character.
Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
---
M src/kudu/tools/diagnostics_log_parser.cc
M src/kudu/tools/diagnostics_log_parser.h
M src/kudu/tools/kudu-tool-test.cc
3 files changed, 80 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/20741/3
--
To view, visit http://gerrit.cloudera.org:8080/20741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] disambiguate parse metrics' output
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20741 )
Change subject: [tools] disambiguate parse_metrics' output
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20741/2/src/kudu/tools/diagnostics_log_parser.h
File src/kudu/tools/diagnostics_log_parser.h:
http://gerrit.cloudera.org:8080/#/c/20741/2/src/kudu/tools/diagnostics_log_parser.h@216
PS2, Line 216: signle
> nit: single
Done
--
To view, visit http://gerrit.cloudera.org:8080/20741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba0bc90a6313bd9096fa1493dd902254cdda1dc1
Gerrit-Change-Number: 20741
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 01 Dec 2023 04:23:40 +0000
Gerrit-HasComments: Yes