You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/20 09:32:07 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

jamesnetherton opened a new issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108


   Follow up to https://github.com/apache/camel-quarkus/issues/843.
   
   As noted in https://github.com/apache/camel-quarkus/issues/699, utilizing `AbstractApiComponent`, results in any of its supporting classes that use `@UriParams` to be registered for reflection. Currently this applies to extensions:
   
   * Box
   * Braintree
   * Olingo4
   
   It'd be good to investigate whether we can fix this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108#issuecomment-634544094


   I have filed an issue in Camel https://issues.apache.org/jira/browse/CAMEL-15119


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108#issuecomment-648054322


   > @jamesnetherton you are surely welcome to test with camel master
   
   I'll do, it is my responsibility this week.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108#issuecomment-669769198


   I gave this a quick test with 3.5.0-SNAPSHOT and unfortunately hit some issues in native mode.
   
   Seems we still have some logic that relies on reflective access to the component configuration classes.
   
   https://github.com/apache/camel/blob/master/core/camel-support/src/main/java/org/apache/camel/support/component/AbstractApiProducer.java#L171
   
   @davsclaus do you think that can be fixed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108#issuecomment-669817235


   Tested box, braintree & olingo4 and they now all work fine in native mode without the configuration classes registered for reflection :+1: 
   
   Probably a separate discussion to this issue, but we could also remove the policy extension as proposed in https://github.com/apache/camel-quarkus/issues/699.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] davsclaus commented on issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108#issuecomment-647431814


   I am working on this and have also created a ticket
   https://issues.apache.org/jira/browse/CAMEL-15224


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] davsclaus commented on issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108#issuecomment-669783517


   @jamesnetherton yeah can you try with this commit (rebuild camel-core)
   https://github.com/apache/camel/commit/96034dd0f964a31f1e8ee72409dcd848b78ef560


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] davsclaus commented on issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108#issuecomment-648029282


   Okay so in Camel 3.5 we have removed the reflection in those api components. @jamesnetherton you are surely welcome to test with camel master if you can native compile and have those configuration classes no longer registerered for reflection


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton closed issue #1108: Investigate removing reflective class configuration for components that extend AbstractApiComponent

Posted by GitBox <gi...@apache.org>.
jamesnetherton closed issue #1108:
URL: https://github.com/apache/camel-quarkus/issues/1108


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org