You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/13 22:48:47 UTC
[GitHub] [flink] RyanSkraba opened a new pull request, #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
RyanSkraba opened a new pull request, #20267:
URL: https://github.com/apache/flink/pull/20267
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
The FileSystemBehaviorTestSuite in flink-core has an implementation in most modules in flink-filesystems. All of these implementations (one for each filesystem) should be migrated together.
## Brief change log
This change is a code cleanup without any test coverage.
For the tests that can be locally, I verified that no tests were deleted. Some of the tests have changed their names.
Especially note the technique of the inner class in `AzureFileSystemBehaviorITCase`: The https scheme tests are always performed, but the static inner class should repeat the tests with http support only if the best effort check succeeds.
## Verifying this change
This change is a code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20267:
URL: https://github.com/apache/flink/pull/20267#discussion_r1003339435
##########
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java:
##########
@@ -70,12 +60,30 @@ public class AzureFileSystemBehaviorITCase extends FileSystemBehaviorTestSuite {
private static final String TEST_DATA_DIR = "tests-" + UUID.randomUUID();
- // Azure Blob Storage defaults to https only storage accounts. We check if http support has been
- // enabled on a best effort basis and test http if so.
- @Parameterized.Parameters(name = "Scheme = {0}")
- public static List<String> parameters() throws IOException {
- boolean httpsOnly = isHttpsTrafficOnly();
- return httpsOnly ? Arrays.asList("wasbs") : Arrays.asList("wasb", "wasbs");
+ /**
+ * Azure Blob Storage defaults to https only storage accounts, tested in the base class.
+ *
+ * <p>This nested class repeats the tests with http support, but only if a best effort check on
+ * https support succeeds.
+ */
+ static class HttpSupportAzureFileSystemBehaviorITCase extends AzureFileSystemBehaviorITCase {
Review Comment:
I don't think this makes a significant difference to warrant the change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp merged pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
XComp merged PR #20267:
URL: https://github.com/apache/flink/pull/20267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20267:
URL: https://github.com/apache/flink/pull/20267#discussion_r1003342134
##########
flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemBehaviorTest.java:
##########
@@ -23,26 +23,25 @@
import org.apache.flink.core.fs.FileSystemKind;
import org.apache.flink.core.fs.Path;
-import org.junit.Rule;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.io.TempDir;
/** Behavior tests for Flink's {@link LocalFileSystem}. */
-public class LocalFileSystemBehaviorTest extends FileSystemBehaviorTestSuite {
+class LocalFileSystemBehaviorTest extends FileSystemBehaviorTestSuite {
- @Rule public final TemporaryFolder tmp = new TemporaryFolder();
+ @TempDir private java.nio.file.Path tmp;
Review Comment:
See above -- I didn't change this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #20267:
URL: https://github.com/apache/flink/pull/20267#issuecomment-1185538176
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20267:
URL: https://github.com/apache/flink/pull/20267#discussion_r1003341622
##########
flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HdfsBehaviorTest.java:
##########
@@ -47,19 +43,17 @@ public class HdfsBehaviorTest extends FileSystemBehaviorTestSuite {
// ------------------------------------------------------------------------
- @BeforeClass
- public static void verifyOS() {
- Assume.assumeTrue(
- "HDFS cluster cannot be started on Windows without extensions.",
- !OperatingSystem.isWindows());
+ @BeforeAll
+ static void verifyOS() {
+ assumeThat(OperatingSystem.isWindows())
+ .describedAs("HDFS cluster cannot be started on Windows without extensions.")
+ .isFalse();
}
- @BeforeClass
- public static void createHDFS() throws Exception {
- final File baseDir = TMP.newFolder();
-
+ @BeforeAll
+ static void createHDFS(@TempDir java.nio.file.Path tmp) throws Exception {
Review Comment:
I made this change because of the `getAbsolutePath`, but I'd argue that it's strictly not necessary or desireable to avoid fully qualified classes! Most uses of `@TempDir` are on `java.nio` classes I believe!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #20267:
URL: https://github.com/apache/flink/pull/20267#discussion_r1004484209
##########
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java:
##########
@@ -70,25 +60,43 @@ public class AzureFileSystemBehaviorITCase extends FileSystemBehaviorTestSuite {
private static final String TEST_DATA_DIR = "tests-" + UUID.randomUUID();
- // Azure Blob Storage defaults to https only storage accounts. We check if http support has been
- // enabled on a best effort basis and test http if so.
- @Parameterized.Parameters(name = "Scheme = {0}")
- public static List<String> parameters() throws IOException {
- boolean httpsOnly = isHttpsTrafficOnly();
- return httpsOnly ? Arrays.asList("wasbs") : Arrays.asList("wasb", "wasbs");
- }
-
- private static boolean isHttpsTrafficOnly() throws IOException {
- if (StringUtils.isNullOrWhitespaceOnly(RESOURCE_GROUP)
- || StringUtils.isNullOrWhitespaceOnly(TOKEN_CREDENTIALS_FILE)) {
+ /**
+ * Azure Blob Storage defaults to https only storage accounts, tested in the base class.
+ *
+ * <p>This nested class repeats the tests with http support, but only if a best effort check on
+ * https support succeeds.
+ */
+ static class HttpSupportAzureFileSystemBehaviorITCase extends AzureFileSystemBehaviorITCase {
+ @BeforeAll
+ static void onlyRunIfHttps() throws IOException {
// default to https only, as some fields are missing
- return true;
+ assumeThat(RESOURCE_GROUP)
+ .describedAs("Azure resource group not configured, skipping test...")
+ .isNotBlank();
+ assumeThat(TOKEN_CREDENTIALS_FILE)
+ .describedAs("Azure token credentials not configured, skipping test...")
+ .isNotBlank();
+ assumeThat(ACCOUNT)
Review Comment:
Shouldn't we also call assume on `CONTAINER` since it's used for the URL generation? :thinking:
##########
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java:
##########
@@ -102,49 +110,48 @@ private static boolean isHttpsTrafficOnly() throws IOException {
.enableHttpsTrafficOnly();
}
- @BeforeClass
- public static void checkCredentialsAndSetup() throws IOException {
+ @BeforeAll
+ static void checkCredentialsAndSetup() {
// check whether credentials and container details exist
- Assume.assumeTrue(
- "Azure container not configured, skipping test...",
- !StringUtils.isNullOrWhitespaceOnly(CONTAINER));
- Assume.assumeTrue(
- "Azure access key not configured, skipping test...",
- !StringUtils.isNullOrWhitespaceOnly(ACCESS_KEY));
+ assumeThat(CONTAINER)
+ .describedAs("Azure container not configured, skipping test...")
+ .isNotBlank();
+ assumeThat(ACCESS_KEY)
+ .describedAs("Azure access key not configured, skipping test...")
+ .isNotBlank();
// initialize configuration with valid credentials
final Configuration conf = new Configuration();
// fs.azure.account.key.youraccount.blob.core.windows.net = ACCESS_KEY
conf.setString("fs.azure.account.key." + ACCOUNT + ".blob.core.windows.net", ACCESS_KEY);
Review Comment:
Shouldn't we also add an assume on `ACCOUNT` since we're using it in the parameter name and when generating the base URL? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
XComp commented on code in PR #20267:
URL: https://github.com/apache/flink/pull/20267#discussion_r989152235
##########
flink-core/src/test/java/org/apache/flink/core/fs/local/LocalFileSystemBehaviorTest.java:
##########
@@ -23,26 +23,25 @@
import org.apache.flink.core.fs.FileSystemKind;
import org.apache.flink.core.fs.Path;
-import org.junit.Rule;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.io.TempDir;
/** Behavior tests for Flink's {@link LocalFileSystem}. */
-public class LocalFileSystemBehaviorTest extends FileSystemBehaviorTestSuite {
+class LocalFileSystemBehaviorTest extends FileSystemBehaviorTestSuite {
- @Rule public final TemporaryFolder tmp = new TemporaryFolder();
+ @TempDir private java.nio.file.Path tmp;
Review Comment:
Using `File` here would prevent you from using a full reference of the type here
##########
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java:
##########
@@ -70,12 +60,30 @@ public class AzureFileSystemBehaviorITCase extends FileSystemBehaviorTestSuite {
private static final String TEST_DATA_DIR = "tests-" + UUID.randomUUID();
- // Azure Blob Storage defaults to https only storage accounts. We check if http support has been
- // enabled on a best effort basis and test http if so.
- @Parameterized.Parameters(name = "Scheme = {0}")
- public static List<String> parameters() throws IOException {
- boolean httpsOnly = isHttpsTrafficOnly();
- return httpsOnly ? Arrays.asList("wasbs") : Arrays.asList("wasb", "wasbs");
+ /**
+ * Azure Blob Storage defaults to https only storage accounts, tested in the base class.
+ *
+ * <p>This nested class repeats the tests with http support, but only if a best effort check on
+ * https support succeeds.
+ */
+ static class HttpSupportAzureFileSystemBehaviorITCase extends AzureFileSystemBehaviorITCase {
Review Comment:
hm, I'm wondering whether it should be a separate test class instead of an inner one. But I don't have a strong opinion here. :thinking: So, I guess, it's good enough :shrug:
##########
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java:
##########
@@ -85,9 +93,9 @@ private static boolean isHttpsTrafficOnly() throws IOException {
return true;
}
- Assume.assumeTrue(
- "Azure storage account not configured, skipping test...",
- !StringUtils.isNullOrWhitespaceOnly(ACCOUNT));
+ assumeThat(ACCOUNT)
+ .describedAs("Azure storage account not configured, skipping test...")
+ .isNotBlank();
Review Comment:
Could we clean it up a bit. I wouldn't expected `assumeThat` to be called within `isHttpsTrafficOnly`.
##########
flink-core/src/test/java/org/apache/flink/core/fs/FileSystemBehaviorTestSuite.java:
##########
@@ -82,141 +80,142 @@ public void cleanup() throws Exception {
// --- file system kind
@Test
- public void testFileSystemKind() {
- assertEquals(getFileSystemKind(), fs.getKind());
+ void testFileSystemKind() {
+ assertThat(fs.getKind()).isEqualTo(getFileSystemKind());
}
// --- access and scheme
@Test
- public void testPathAndScheme() throws Exception {
- assertEquals(fs.getUri(), getBasePath().getFileSystem().getUri());
- assertEquals(fs.getUri().getScheme(), getBasePath().toUri().getScheme());
+ void testPathAndScheme() throws Exception {
+ assertThat(fs.getUri()).isEqualTo(getBasePath().getFileSystem().getUri());
+ assertThat(fs.getUri().getScheme()).isEqualTo(getBasePath().toUri().getScheme());
}
@Test
- public void testHomeAndWorkDir() {
- assertEquals(fs.getUri().getScheme(), fs.getWorkingDirectory().toUri().getScheme());
- assertEquals(fs.getUri().getScheme(), fs.getHomeDirectory().toUri().getScheme());
+ void testHomeAndWorkDir() {
+ assertThat(fs.getUri().getScheme())
+ .isEqualTo(fs.getWorkingDirectory().toUri().getScheme())
+ .isEqualTo(fs.getHomeDirectory().toUri().getScheme());
Review Comment:
```suggestion
@Test
void testHomeDirScheme() {
assertThat(fs.getHomeDirectory().toUri().getScheme()).isEqualTo(fs.getUri().getScheme());
}
@Test
void testWorkDirScheme() {
assertThat(fs.getWorkingDirectory().toUri().getScheme()).isEqualTo(fs.toUri().getScheme());
}
```
nit: `actual` and `expected` are swapped here, I guess (we're actually testing the working directory and home directory). I was wondering whether it make sense to split these two up into two separate test cases. Additionally, we could add better naming. I know that this is nitpicking. I'll leave it up to you. Splitting the test up into two should be done in a separate hotfix commit, though.
##########
flink-filesystems/flink-hadoop-fs/src/test/java/org/apache/flink/runtime/fs/hdfs/HdfsBehaviorTest.java:
##########
@@ -47,19 +43,17 @@ public class HdfsBehaviorTest extends FileSystemBehaviorTestSuite {
// ------------------------------------------------------------------------
- @BeforeClass
- public static void verifyOS() {
- Assume.assumeTrue(
- "HDFS cluster cannot be started on Windows without extensions.",
- !OperatingSystem.isWindows());
+ @BeforeAll
+ static void verifyOS() {
+ assumeThat(OperatingSystem.isWindows())
+ .describedAs("HDFS cluster cannot be started on Windows without extensions.")
+ .isFalse();
}
- @BeforeClass
- public static void createHDFS() throws Exception {
- final File baseDir = TMP.newFolder();
-
+ @BeforeAll
+ static void createHDFS(@TempDir java.nio.file.Path tmp) throws Exception {
Review Comment:
You could use `File` instead of `java.nio.file.Path`. This way, you avoid using a qualified type here and there's no need to call `toString()` further down in line 56 because there's `tmp.getAbsolutePath()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20267:
URL: https://github.com/apache/flink/pull/20267#discussion_r1003338793
##########
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java:
##########
@@ -85,9 +93,9 @@ private static boolean isHttpsTrafficOnly() throws IOException {
return true;
}
- Assume.assumeTrue(
- "Azure storage account not configured, skipping test...",
- !StringUtils.isNullOrWhitespaceOnly(ACCOUNT));
+ assumeThat(ACCOUNT)
+ .describedAs("Azure storage account not configured, skipping test...")
+ .isNotBlank();
Review Comment:
I rewrote the logic here so that all of the `assumeThat` are more explicit. I'm pretty sure it's equivalent, but I'd appreciate a bit of extra review on this change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20267:
URL: https://github.com/apache/flink/pull/20267#issuecomment-1183759359
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d170e195c29a78faad843c65795dbad8a8be9ec2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d170e195c29a78faad843c65795dbad8a8be9ec2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d170e195c29a78faad843c65795dbad8a8be9ec2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] RyanSkraba commented on a diff in pull request #20267: [FLINK-28542][tests][JUnit5 Migration] FileSystemBehaviorTestSuite
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #20267:
URL: https://github.com/apache/flink/pull/20267#discussion_r1005653819
##########
flink-filesystems/flink-azure-fs-hadoop/src/test/java/org/apache/flink/fs/azurefs/AzureFileSystemBehaviorITCase.java:
##########
@@ -70,25 +60,43 @@ public class AzureFileSystemBehaviorITCase extends FileSystemBehaviorTestSuite {
private static final String TEST_DATA_DIR = "tests-" + UUID.randomUUID();
- // Azure Blob Storage defaults to https only storage accounts. We check if http support has been
- // enabled on a best effort basis and test http if so.
- @Parameterized.Parameters(name = "Scheme = {0}")
- public static List<String> parameters() throws IOException {
- boolean httpsOnly = isHttpsTrafficOnly();
- return httpsOnly ? Arrays.asList("wasbs") : Arrays.asList("wasb", "wasbs");
- }
-
- private static boolean isHttpsTrafficOnly() throws IOException {
- if (StringUtils.isNullOrWhitespaceOnly(RESOURCE_GROUP)
- || StringUtils.isNullOrWhitespaceOnly(TOKEN_CREDENTIALS_FILE)) {
+ /**
+ * Azure Blob Storage defaults to https only storage accounts, tested in the base class.
+ *
+ * <p>This nested class repeats the tests with http support, but only if a best effort check on
+ * https support succeeds.
+ */
+ static class HttpSupportAzureFileSystemBehaviorITCase extends AzureFileSystemBehaviorITCase {
+ @BeforeAll
+ static void onlyRunIfHttps() throws IOException {
// default to https only, as some fields are missing
- return true;
+ assumeThat(RESOURCE_GROUP)
+ .describedAs("Azure resource group not configured, skipping test...")
+ .isNotBlank();
+ assumeThat(TOKEN_CREDENTIALS_FILE)
+ .describedAs("Azure token credentials not configured, skipping test...")
+ .isNotBlank();
+ assumeThat(ACCOUNT)
Review Comment:
This is covered by the `@BeforeAll` in the base class. If I read the logic correctly, ACCOUNT should also be skipped in the base class! Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org