You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by beriaanirudh <gi...@git.apache.org> on 2017/02/03 10:51:22 UTC
[GitHub] zeppelin pull request #1971: When gear icon is clicked, scroll the page to t...
GitHub user beriaanirudh opened a pull request:
https://github.com/apache/zeppelin/pull/1971
When gear icon is clicked, scroll the page to the top to show the interpreter bindings
### What is this PR for?
When someone is browsing a notebook and they click the *gear* button of interpreter bindings, the bindings do come up, but the person might not realize since it opens on the top of the page, and they don't get any feedback that the bindings have opened. We should scroll up the page to show the bindings. This will also act as the feedback of clicking the *gear* button.
### What type of PR is it?
[Improvement]
### Todos
* None
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2047
### How should this be tested?
Create few (say 10) paragraphs and scroll down to the last paragraph. Now click the *gear* icon meant to open the interpreter bindings. The view should have scrolled up to show the bindings.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No. Its a usability improvement.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/beriaanirudh/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1971.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1971
----
commit a0f521af621ca6632d7648f019bf3b71d0be2bca
Author: Beria <be...@qubole.com>
Date: 2017-02-03T08:35:49Z
When gear icon is clicked, scroll the page to the top to show the intepreter bindings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1971: When gear icon is clicked, scroll the page to the top ...
Posted by beriaanirudh <gi...@git.apache.org>.
Github user beriaanirudh commented on the issue:
https://github.com/apache/zeppelin/pull/1971
I checked the CI failure, it does not look relevant to this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1971: When gear icon is clicked, scroll the page to the top ...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1971
Thanks @beriaanirudh for ux improvement!
Looks good to me. Merge to master if no more comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1971: When gear icon is clicked, scroll the page to the top ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1971
Great fix, interesting approach.
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1971: When gear icon is clicked, scroll the page to t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1971
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---