You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sgrebnov <gi...@git.apache.org> on 2014/08/15 12:11:40 UTC

[GitHub] cordova-windows pull request: Use '--win' switch instead of '--sto...

GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-windows/pull/39

    Use '--win' switch instead of '--store' for Windows desktop/tablet build

    After additional discussion it is proposed to replace --store with --win as the most understandable for the developers and address future names/strings/terminology changes.
    
    As a result we will have --phone and --win switches.
    
    Pull request consists of two commits:
    1. First one just replaces switch name
    2. The second one goes further and reflects this change to project structure which is visible in build logs and if manually open platform in Visual Studio (for consistency reason) and to use Windows suffix in produced build artifacts:
    before: 
        CordovaApp.Store_0.0.1.0_anycpu_debug
        CordovaApp.Phone_0.0.1.0_anycpu_debug
    after: 
        CordovaApp.Windows_0.0.1.0_anycpu_debug
        CordovaApp.Phone_0.0.1.0_anycpu_debug


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-windows target-switch-name

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
    
----
commit e7e211b3b155e2dcf872feca2a79ad0ebe13ee49
Author: sgrebnov <v-...@microsoft.com>
Date:   2014-08-15T09:27:10Z

    CB-6976 Changes switch name from '--store' to '--win'

commit 3fcac52cf651d2a5de842cb356ba367d9ed5b454
Author: sgrebnov <v-...@microsoft.com>
Date:   2014-08-15T10:00:51Z

    CB-6976 Reflect new switch name to project structure
    
    For consistence reason.
    
    1. Produce correct artefact names: Windows instead of Store
    before: CordovaApp.Store_0.0.1.0_anycpu_debug
    after: CordovaApp.Windows_0.0.1.0_anycpu_debug
    
    2. Use <Windows> instead of <Store> suffix for file names to be consistent with terminology used in config.xml and command line switch and be more understanable for developers

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-windows pull request: Use '--win' switch instead of '--sto...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-windows/pull/39


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---