[GitHub] [incubator-brpc] lingbin commented on issue #733: Add a gflag to enable tcp keepalive

[GitBox <gi...@apache.org>]

lingbin commented on issue #733: Add a gflag to enable tcp keepalive
URL: https://github.com/apache/incubator-brpc/pull/733#issuecomment-484335075
 
 
   @zyearn  thanks for your review
   
   when the default value of `socket_enable_tcp_keepalive` is true, the error message in some UT is 
   
   > Fail to set enable keepalive of fd=4: **Socket operation on non-socket**. 
   
   So there should be some places where a non-socket fd is used to create the brpc::Socket object (a clue is from the above error, which is the value of fd is 4, indicating that its high probability is not a real socket fd).
   
   Change the default value of `socket_enable_tcp_keepalive` to false, which can maintain the same behavior as the original, just like the existing socket configuration (such as FLAGS_socket_send_buffer_size). That is, if the default value of `FLAGS_socket_send_buffer_size` is greater than 0, then there will be similar problems.
   
   BTW, I am sorry that I am unable to find a more detailed reason for now, because I am currently experiencing some problems during compilation (should be due to my machine environment), resulting in the inability to perform sufficient GDB. After I solved the current compile problem, I am willing to do it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org