[GitHub] Myracle commented on issue #7226: FLINK-11050 add lowerBound and upperBound for optimizing RocksDBMapState's entries

[GitBox <gi...@apache.org>]

Myracle commented on issue #7226: FLINK-11050 add lowerBound and upperBound for optimizing RocksDBMapState's entries
URL: https://github.com/apache/flink/pull/7226#issuecomment-445098945
 
 
   > Hi @Myracle, thanks for the PR. I think we should either support the new API for all `MapState` implementations or declare the method as a best-effort filter (which means we have to manually filter the returned entries).
   > 
   > What do you think about this @StefanRRichter?
   > 
   > Best, Fabian
   
   Thank you for your reply. The lowerBound and upperBound are used by RocksDB's interface to avoid wasting time on deleted values. The situation is not the same when storing state in heap. Do you still think that we should support the new API for all `MapState` implementations? Also, I do not understand the meaning of "declare the method as a best-effort filter". Because previous implementation will return all the values and it is just the bottleneck in our situation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services