[GitHub] [helix] xyuanlu commented on a diff in pull request #2333: Prepare zkclient for meta-client DataChangeListener implementation

[GitBox <gi...@apache.org>]

xyuanlu commented on code in PR #2333:
URL: https://github.com/apache/helix/pull/2333#discussion_r1062911817


##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -247,4 +249,39 @@ public boolean[] set(List keys, List values, List version) {
   public List<OpResult> transactionOP(Iterable iterable) {
     return null;
   }
+
+  /**
+   * A converter class to transform {@link DataChangeListener} to {@link IZkDataListener}
+   */
+  static class DataListenerConverter implements IZkDataListener {

Review Comment:
   May I ask why we need this class? Can zkMetaCLient implement IZkDataListener? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org