You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/25 03:29:58 UTC

[GitHub] [pulsar] yangl commented on a change in pull request #11068: ignore the NotAllowedException when general metric data.

yangl commented on a change in pull request #11068:
URL: https://github.com/apache/pulsar/pull/11068#discussion_r658449241



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TransactionAggregator.java
##########
@@ -67,7 +68,11 @@ public static void generate(PulsarService pulsar, SimpleTextOutputStream stream,
                                     generateManageLedgerStats(managedLedger,
                                             stream, cluster, namespace, name, subscription.getName());
                                 } catch (Exception e) {
-                                    log.warn("Transaction pending ack generate managedLedgerStats fail!", e);
+                                    if (e.getCause() instanceof BrokerServiceException.NotAllowedException) {

Review comment:
       yeah, good idea. done. Thanks a lot.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org