You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/05/10 22:42:04 UTC
[GitHub] [ozone] jojochuang opened a new pull request, #3400: HDDS-6723. Close Rocks objects properly in OzoneManager
jojochuang opened a new pull request, #3400:
URL: https://github.com/apache/ozone/pull/3400
Change-Id: I5e2f906508d92c1c21555aa51d9b5c97744f26cd
(cherry picked from commit c1cda1d8e99555282b991f174d0bf597c0deb950)
## What changes were proposed in this pull request?
Close RocksDB objects when they are not used.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6723
## How was this patch tested?
This is tested in an internal branch, ran a few workloads.
The RocksDB jar was replaced with a custom build which prints memory leak in stdout. This is the code: https://github.com/jojochuang/rocksdb/commits/debug_memory_leak
With this change, most of the leaks are now gone, except during OM initialization when load DB. Didn't care much about them as they account for very little memory usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #3400: HDDS-6723. Close Rocks objects properly in OzoneManager
Posted by GitBox <gi...@apache.org>.
jojochuang commented on PR #3400:
URL: https://github.com/apache/ozone/pull/3400#issuecomment-1122989144
[om_stdout.log](https://github.com/apache/ozone/files/8665431/om_stdout.log)
Sample stdout from OM after this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3400: HDDS-6723. Close Rocks objects properly in OzoneManager
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3400:
URL: https://github.com/apache/ozone/pull/3400#issuecomment-1172956680
Thanks @jojochuang for the patch, @kerneltime for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3400: HDDS-6723. Close Rocks objects properly in OzoneManager
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3400:
URL: https://github.com/apache/ozone/pull/3400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on pull request #3400: HDDS-6723. Close Rocks objects properly in OzoneManager
Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3400:
URL: https://github.com/apache/ozone/pull/3400#issuecomment-1129578874
The changes here are in the right direction but this will need to be updated post merge of https://github.com/apache/ozone/pull/3426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org