You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2019/12/23 08:58:53 UTC

[cordova-windows] branch brodybits-uwp-only-test-wip0700 updated (68b6455 -> 0b5a05e)

This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a change to branch brodybits-uwp-only-test-wip0700
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git.


    from 68b6455  AppVeyor testing on Node.js 10 & 12
     new abf94af  [TBD WITH A TODO ITEM] AppVeyor drop testing on Node.js 6
     new 0b5a05e  Remove support for VS 14 (Visual Studio 2015)

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 appveyor.yml                         |  7 -------
 template/cordova/lib/MSBuildTools.js | 12 +-----------
 2 files changed, 1 insertion(+), 18 deletions(-)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[cordova-windows] 01/02: [TBD WITH A TODO ITEM] AppVeyor drop testing on Node.js 6

Posted by br...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-uwp-only-test-wip0700
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit abf94af2a7c0dfbed9a53a9b56daf1312024be0d
Author: Christopher J. Brody <ch...@brody.consulting>
AuthorDate: Mon Dec 23 03:56:52 2019 -0500

    [TBD WITH A TODO ITEM] AppVeyor drop testing on Node.js 6
    
    TODO: should first update the package engines to drop Node.js <10
---
 appveyor.yml | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/appveyor.yml b/appveyor.yml
index 29d4c3c..2dfbedb 100644
--- a/appveyor.yml
+++ b/appveyor.yml
@@ -21,13 +21,6 @@
 
 environment:
   matrix:
-    - nodejs_version: "6"
-      APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-
-    - nodejs_version: "6"
-      APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
-      MSBUILDDIR: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Community\\MSBuild\\15.0\\Bin\\"
-
     - nodejs_version: 10
       APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
 


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[cordova-windows] 02/02: Remove support for VS 14 (Visual Studio 2015)

Posted by br...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

brodybits pushed a commit to branch brodybits-uwp-only-test-wip0700
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git

commit 0b5a05e93b6f03404f645443a9d52032aae42766
Author: Christopher J. Brody <ch...@brody.consulting>
AuthorDate: Mon Dec 23 03:57:32 2019 -0500

    Remove support for VS 14 (Visual Studio 2015)
    
    with an updated error message
    
    and update a comment regarding the Visual Studio build tooling
    
    Co-authored-by: Jan Piotrowski <pi...@gmail.com>
    Co-authored-by: Christopher J. Brody <ch...@brody.consulting>
---
 template/cordova/lib/MSBuildTools.js | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/template/cordova/lib/MSBuildTools.js b/template/cordova/lib/MSBuildTools.js
index 90501b8..aed92eb 100644
--- a/template/cordova/lib/MSBuildTools.js
+++ b/template/cordova/lib/MSBuildTools.js
@@ -261,14 +261,6 @@ var projFiles = {
     win10: 'CordovaApp.Windows10.jsproj'
 };
 
-// TODO: Fix this so that it outlines supported versions based on version criteria:
-// - v15.5: Windows 10 only
-// - v15.x: TBD
-// - v14: Windows 8.1 (no longer supported), Windows 10
-function msBuild14TargetsFilter (target) {
-    return target === projFiles.win10;
-}
-
 function msBuild15TargetsFilter (target) {
     return target === projFiles.win10;
 }
@@ -285,7 +277,6 @@ function filterSupportedTargets (targets, msbuild) {
     }
 
     var targetFilters = {
-        '14.0': msBuild14TargetsFilter,
         '15.x': msBuild15TargetsFilter,
         '15.5': msBuild155TargetsFilter,
         get: function (version) {
@@ -305,8 +296,7 @@ function filterSupportedTargets (targets, msbuild) {
     // unsupported targets have been detected
     if (supportedTargets.length !== targets.length) {
         events.emit('warn', 'Not all desired build targets are compatible with the current build environment. ' +
-            'Please install Visual Studio 2015 for Windows 8.1 and Windows 10, ' +
-            'or Visual Studio 2013 Update 2 for Windows 8.1.');
+            'Please install Visual Studio 2017.');
     }
     return supportedTargets;
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org