[GitHub] [arrow-ballista] Dandandan commented on a diff in pull request #380: Pull-based execution loop improvements

[GitBox <gi...@apache.org>]

Dandandan commented on code in PR #380:
URL: https://github.com/apache/arrow-ballista/pull/380#discussion_r999615078


##########
ballista/executor/src/execution_loop.rs:
##########
@@ -162,7 +165,7 @@ async fn run_received_tasks<T: 'static + AsLogicalPlan, U: 'static + AsExecution
         task_id, job_id, stage_id, stage_attempt_num, partition_id, task_attempt_num
     );
     info!("Received task {}", task_identity);
-    available_tasks_slots.fetch_sub(1, Ordering::SeqCst);
+    let permit = available_task_slots.clone().acquire_owned().await.unwrap();

Review Comment:
   I can't see whether that happens, as we also wait until there is a slot available before polling (so at this point there should be at least one available.
   
   But I can see if I can make it not need the first check at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org