You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/24 00:42:04 UTC
[GitHub] [incubator-superset] nytai commented on a change in pull request #11030: feat: add "created by" to dashboard CRUD view
nytai commented on a change in pull request #11030:
URL: https://github.com/apache/incubator-superset/pull/11030#discussion_r493974720
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -337,6 +350,26 @@ function DashboardList(props: DashboardListProps) {
),
paginate: true,
},
+ {
+ Header: t('Created By'),
+ id: 'created_by',
+ input: 'select',
+ operator: 'rel_o_m',
+ unfilteredLabel: 'All',
+ fetchSelects: createFetchRelated(
+ 'dashboard',
+ 'created_by',
+ createErrorHandler(errMsg =>
+ props.addDangerToast(
+ t(
+ 'An error occurred while fetching chart dataset values: %s',
Review comment:
```suggestion
'An error occurred while fetching dashboard created by values: %s',
```
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx
##########
@@ -337,6 +350,26 @@ function DashboardList(props: DashboardListProps) {
),
paginate: true,
},
+ {
+ Header: t('Created By'),
+ id: 'created_by',
+ input: 'select',
+ operator: 'rel_o_m',
+ unfilteredLabel: 'All',
+ fetchSelects: createFetchRelated(
+ 'dashboard',
+ 'created_by',
+ createErrorHandler(errMsg =>
+ props.addDangerToast(
+ t(
+ 'An error occurred while fetching chart dataset values: %s',
Review comment:
can you also change the error message in the "owners" filter to say `dashboard` instead of `chart`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org