You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/05/15 22:44:20 UTC

[GitHub] [mynewt-core] vrahane commented on issue #1820: sensors/bma253: sensor driver with the following changes

vrahane commented on issue #1820: sensors/bma253: sensor driver with the following changes
URL: https://github.com/apache/mynewt-core/pull/1820#issuecomment-492851444
 
 
   @bstbud Can you please address the PR based on the review that @kasjer did and remove the API which wraps the cputime delay API.
   
   Also, on line `3263` `    fifo_cfg.fifo_mode = FIFO_MODE_STREAM;` should be `BYPASS` since we want it to default to POLLING mode by default, so the FIFOs are bypassed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services