You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "lightClouds917 (via GitHub)" <gi...@apache.org> on 2024/03/12 12:05:24 UTC
[PR] optimize: add version to the console banner [incubator-seata]
lightClouds917 opened a new pull request, #6417:
URL: https://github.com/apache/incubator-seata/pull/6417
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
add version to the console banner
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #6416
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add version to the console banner [incubator-seata]
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan commented on code in PR #6417:
URL: https://github.com/apache/incubator-seata/pull/6417#discussion_r1732308122
##########
changes/en-us/2.x.md:
##########
@@ -31,6 +31,96 @@ Add changes here for all PR submitted to the 2.x branch.
### optimize:
+- [[#6031](https://github.com/apache/incubator-seata/pull/6031)] add a check for the existence of the undolog table
Review Comment:
Why does this submission have so many doc instructions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add version to the console banner [incubator-seata]
Posted by "lightClouds917 (via GitHub)" <gi...@apache.org>.
lightClouds917 commented on PR #6417:
URL: https://github.com/apache/incubator-seata/pull/6417#issuecomment-2311691435
> Conflicts need to be resolved
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add version to the console banner [incubator-seata]
Posted by "lightClouds917 (via GitHub)" <gi...@apache.org>.
lightClouds917 commented on code in PR #6417:
URL: https://github.com/apache/incubator-seata/pull/6417#discussion_r1524569842
##########
server/src/main/java/org/apache/seata/server/ServerApplication.java:
##########
@@ -18,15 +18,32 @@
import java.io.IOException;
+import org.apache.seata.core.protocol.Version;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
/**
+ * Server Application
*/
@SpringBootApplication(scanBasePackages = {"org.apache.seata"})
public class ServerApplication {
public static void main(String[] args) throws IOException {
// run the spring-boot application
- SpringApplication.run(ServerApplication.class, args);
+ SpringApplication app = new SpringApplication(ServerApplication.class);
+ // set the banner and version information
+ app.setBanner((environment, sourceClass, out) -> {
+ out.println("====================================================================");
+ out.println(" _ _____ _ \n" +
Review Comment:
Version information cannot be dynamically obtained from reading from a banner.txt file，i will try another way.
let me see see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add version to the console banner [incubator-seata]
Posted by "xingfudeshi (via GitHub)" <gi...@apache.org>.
xingfudeshi commented on PR #6417:
URL: https://github.com/apache/incubator-seata/pull/6417#issuecomment-2413137392
@lightClouds917 Please resolve conflicting files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add version to the console banner [incubator-seata]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6417:
URL: https://github.com/apache/incubator-seata/pull/6417#issuecomment-1991521086
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `8 lines` in your changes are missing coverage. Please review.
> Project coverage is 50.43%. Comparing base [(`f93a721`)](https://app.codecov.io/gh/apache/incubator-seata/commit/f93a721c997d4e1d8021905e0b1f13e2dade6284?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9d7f951`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6417?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/incubator-seata/pull/6417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 2.x #6417 +/- ##
=========================================
Coverage 50.43% 50.43%
- Complexity 5253 5258 +5
=========================================
Files 941 941
Lines 33279 33286 +7
Branches 4035 4035
=========================================
+ Hits 16783 16787 +4
- Misses 14871 14877 +6
+ Partials 1625 1622 -3
```
| [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/seata/server/ServerApplication.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zZXJ2ZXIvU2VydmVyQXBwbGljYXRpb24uamF2YQ==) | `10.00% <0.00%> (-23.34%)` | :arrow_down: |
... and [6 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6417/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add version to the console banner [incubator-seata]
Posted by "leizhiyuan (via GitHub)" <gi...@apache.org>.
leizhiyuan commented on PR #6417:
URL: https://github.com/apache/incubator-seata/pull/6417#issuecomment-2300346522
Conflicts need to be resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add version to the console banner [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #6417:
URL: https://github.com/apache/incubator-seata/pull/6417#discussion_r1527173414
##########
server/src/main/java/org/apache/seata/server/ServerApplication.java:
##########
@@ -18,15 +18,32 @@
import java.io.IOException;
+import org.apache.seata.core.protocol.Version;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
/**
+ * Server Application
*/
@SpringBootApplication(scanBasePackages = {"org.apache.seata"})
public class ServerApplication {
public static void main(String[] args) throws IOException {
// run the spring-boot application
- SpringApplication.run(ServerApplication.class, args);
+ SpringApplication app = new SpringApplication(ServerApplication.class);
+ // set the banner and version information
+ app.setBanner((environment, sourceClass, out) -> {
+ out.println("====================================================================");
+ out.println(" _ _____ _ \n" +
Review Comment:
I don't think it is a good choice to put this graph into the code, which will be less maintainable. Step back, you can read this graph and put it into the output stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] optimize: add version to the console banner [incubator-seata]
Posted by "slievrly (via GitHub)" <gi...@apache.org>.
slievrly commented on code in PR #6417:
URL: https://github.com/apache/incubator-seata/pull/6417#discussion_r1523537441
##########
server/src/main/java/org/apache/seata/server/ServerApplication.java:
##########
@@ -18,15 +18,32 @@
import java.io.IOException;
+import org.apache.seata.core.protocol.Version;
import org.springframework.boot.SpringApplication;
import org.springframework.boot.autoconfigure.SpringBootApplication;
/**
+ * Server Application
*/
@SpringBootApplication(scanBasePackages = {"org.apache.seata"})
public class ServerApplication {
public static void main(String[] args) throws IOException {
// run the spring-boot application
- SpringApplication.run(ServerApplication.class, args);
+ SpringApplication app = new SpringApplication(ServerApplication.class);
+ // set the banner and version information
+ app.setBanner((environment, sourceClass, out) -> {
+ out.println("====================================================================");
+ out.println(" _ _____ _ \n" +
Review Comment:
how about read from file ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org