You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "fornwall (via GitHub)" <gi...@apache.org> on 2026/07/09 23:08:18 UTC

[PR] fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut [arrow-adbc]

fornwall opened a new pull request, #4497:
URL: https://github.com/apache/arrow-adbc/pull/4497

   The FlightSQL test server's `DoPutPreparedStatementQuery` handler returned
   without consuming the client's bound-parameter request stream. gRPC tears
   the stream down as soon as the handler returns, so on a slow/oversubscribed
   runner (observed on arm64 macOS CI) the client's in-flight parameter send
   races the teardown and surfaces as a spurious "EOF (Unknown; ExecuteQuery)"
   instead of the real response, flaking test_stateless_prepared_statement.
   
   Drain the reader before returning so the handler consumes the full request
   stream, per gRPC's contract, removing the race.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #4497:
URL: https://github.com/apache/arrow-adbc/pull/4497#issuecomment-4930353997

   Good find here, but the client should also be fixed to not just report an EOF, if your agent can figure that out...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut [arrow-adbc]

Posted by "fornwall (via GitHub)" <gi...@apache.org>.
fornwall commented on PR #4497:
URL: https://github.com/apache/arrow-adbc/pull/4497#issuecomment-4930366362

   This includes the changes in #4495, as that is necessary to unblock CI and reach the test that this PR aims to fix. But that change can be reviewed and merged in isolation - this test failure surfaces after that fix, but is AFAIK separate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut [arrow-adbc]

Posted by "fornwall (via GitHub)" <gi...@apache.org>.
fornwall commented on PR #4497:
URL: https://github.com/apache/arrow-adbc/pull/4497#issuecomment-4934190812

   > Good find here, but the client should also be fixed to not just report an EOF, if your agent can figure that out...
   
   :robot: made a shot at: https://github.com/apache/arrow-go/pull/920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut [arrow-adbc]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #4497:
URL: https://github.com/apache/arrow-adbc/pull/4497#issuecomment-4937505964

   upstream apache/arrow-go#920 is merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut [arrow-adbc]

Posted by "fornwall (via GitHub)" <gi...@apache.org>.
fornwall commented on PR #4497:
URL: https://github.com/apache/arrow-adbc/pull/4497#issuecomment-4955119233

   > Thanks, can we rebase here?
   
   👍 Done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(go/adbc/driver/flightsql): drain bound-param stream in testserver DoPut [arrow-adbc]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #4497:
URL: https://github.com/apache/arrow-adbc/pull/4497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org