You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by vv...@apache.org on 2022/02/16 03:22:24 UTC
[kafka] branch fix-log4j-appender created (now 05fd4c9)
This is an automated email from the ASF dual-hosted git repository.
vvcephei pushed a change to branch fix-log4j-appender
in repository https://gitbox.apache.org/repos/asf/kafka.git.
at 05fd4c9 KAFKA-13598: set log4j appender to default acks
This branch includes the following new commits:
new 05fd4c9 KAFKA-13598: set log4j appender to default acks
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[kafka] 01/01: KAFKA-13598: set log4j appender to default acks
Posted by vv...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
vvcephei pushed a commit to branch fix-log4j-appender
in repository https://gitbox.apache.org/repos/asf/kafka.git
commit 05fd4c9e313b23814e82ea03cda05c13fac67f1a
Author: John Roesler <vv...@apache.org>
AuthorDate: Tue Feb 15 21:17:34 2022 -0600
KAFKA-13598: set log4j appender to default acks
---
.../java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java b/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
index 23272a2..e7d9509 100644
--- a/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
+++ b/log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java
@@ -74,9 +74,9 @@ public class KafkaLog4jAppender extends AppenderSkeleton {
private String kerb5ConfPath;
private Integer maxBlockMs;
private String sslEngineFactoryClass;
+ private Integer requiredNumAcks;
private int retries = Integer.MAX_VALUE;
- private int requiredNumAcks = 1;
private int deliveryTimeoutMs = 120000;
private int lingerMs = 0;
private int batchSize = 16384;
@@ -285,7 +285,9 @@ public class KafkaLog4jAppender extends AppenderSkeleton {
if (compressionType != null)
props.put(COMPRESSION_TYPE_CONFIG, compressionType);
- props.put(ACKS_CONFIG, Integer.toString(requiredNumAcks));
+ if (requiredNumAcks != null)
+ props.put(ACKS_CONFIG, Integer.toString(requiredNumAcks));
+
props.put(RETRIES_CONFIG, retries);
props.put(DELIVERY_TIMEOUT_MS_CONFIG, deliveryTimeoutMs);
props.put(LINGER_MS_CONFIG, lingerMs);