[jira] [Commented] (CASSANDRA-21785) Support skipping fsync in LogReplica.syncDirectory for tests

["Sam Tunnicliffe (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-21785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18129177#comment-18129177 ] 

Sam Tunnicliffe commented on CASSANDRA-21785:
---------------------------------------------

Looks entirely reasonable & sensible. Are you planning to run CI before committing? I don't think it should be strictly necessary as given the nature of the change here we would really just be asserting that no existing tests where broken by removing fsync from this specific path, which would be highly unexpected and obvious from a post-commit CI run.

Just a minor thing, the PR targets trunk but this is to land in 6.0, right? (Of course, the patch will apply there just fine). 

> Support skipping fsync in LogReplica.syncDirectory for tests
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-21785
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21785
>             Project: Apache Cassandra
>          Issue Type: Improvement
>          Components: Transactional Cluster Metadata
>            Reporter: Dmitry Konstantinov
>            Assignee: Dmitry Konstantinov
>            Priority: Normal
>             Fix For: 6.0.x, 7.x
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> To speedup CI runs we can add support of -Dcassandra.skip_sync=true option to LogReplica.syncDirectory  as we have already in other places.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org