You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "btzq (via GitHub)" <gi...@apache.org> on 2024/04/01 15:55:59 UTC
[I] Export ACL List is missing some data [cloudstack]
btzq opened a new issue, #8862:
URL: https://github.com/apache/cloudstack/issues/8862
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Improvement Request
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
Improvement Request (UI, Functionality)
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.19
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
N/A
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
N/A
##### SUMMARY
<!-- Explain the problem/feature briefly -->
Note: This ticket is broken down as requested from the origianl post, https://github.com/apache/cloudstack/issues/8841
**Export ACL List is missing some data**
- For example, 'Ports' are not available in the exported CSV when exported.
- There may be others that are missing from the CSV output too.
- Exporting the full list as CV makes it very convenient to study, review the rules all at one go using excel.
- If it paired together with 'Import ACL from CSV' https://github.com/apache/cloudstack/issues/8858 , it would make ACL much easier to use all round.
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
N/A
<!-- Paste example playbooks or commands between quotes below -->
~~~
N/A
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
To be able to manage ACL Rules more easily for large scale projects
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
Challenging to use ACL rules for large scale projects.
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export ACL List is missing some data [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #8862:
URL: https://github.com/apache/cloudstack/issues/8862#issuecomment-2049310190
@btzq , with "export", do you mean the output of a tool like cmk?
This seems a UI bug; if the first rule does not have start and end port these wont be in the exported CVS.
Note that the CVS export is a UI feature per se, so no API feature other than the response containing it or not.
This can be solved in the UI or in response (return -1?). I think UI makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export ACL List is missing some data [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on issue #8862:
URL: https://github.com/apache/cloudstack/issues/8862#issuecomment-2134454945
Fixed with #9118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export ACL List is missing some data [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #8862:
URL: https://github.com/apache/cloudstack/issues/8862#issuecomment-2127727233
> @shwstppr , what version of Cloudstack are you using? I am unable to export the 'Startport' and 'EndPort' in the xlsx.
>
> Im using 4.19.0.0
>
> This is my screenshot:
> 
>
> And this is how i exported it:
> 
>
>
Yes, this is consistent with what Daan and me found. It is a ui bug
If the first rule does not have startport and endport (for example a icmp rule), the exported rules do not have startport and endport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export ACL List is missing some data [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on issue #8862:
URL: https://github.com/apache/cloudstack/issues/8862#issuecomment-2124633841
@btzq I tried to check the csv for a rule without any ports and it shows `undefined` against port column. Is this not correct or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export ACL List is missing some data [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on issue #8862:
URL: https://github.com/apache/cloudstack/issues/8862#issuecomment-2128614259
@btzq cc @weizhouapache I missed the fact that it needs to be the first rule without ports. I was able to reproduce and have create a fix in #9118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export ACL List is missing some data [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr closed issue #8862: Export ACL List is missing some data
URL: https://github.com/apache/cloudstack/issues/8862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export ACL List is missing some data [cloudstack]
Posted by "btzq (via GitHub)" <gi...@apache.org>.
btzq commented on issue #8862:
URL: https://github.com/apache/cloudstack/issues/8862#issuecomment-2050838856
@DaanHoogland when i meant 'Export', i meant the existing export function. Exporting via CMK is not required (For us at least).
My thoughts are that if a ACL rule doesnt have a start and end port, the columns should still be exported anyways with just empty value. Putting as -1 instead of empty value also makes sense.
Yes i think this is just a UI issue, the data is already there. So this is another low hanging fruit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Export ACL List is missing some data [cloudstack]
Posted by "btzq (via GitHub)" <gi...@apache.org>.
btzq commented on issue #8862:
URL: https://github.com/apache/cloudstack/issues/8862#issuecomment-2127177207
@shwstppr , what version of Cloudstack are you using? I am unable to export the 'Startport' and 'EndPort' in the xlsx.
Im using 4.19.0.0
This is my screenshot:
And this is how i exported it:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org