You are viewing a plain text version of this content. The canonical link for it is here.
Posted to discuss-archive@tvm.apache.org by GitBox <gi...@apache.org> on 2026/07/02 08:55:14 UTC
[GH] (tvm-ffi/pyobject): Workflow run "CI" failed!
The GitHub Actions job "CI" on tvm-ffi.git/pyobject has failed.
Run started by GitHub user cyx-6 (triggered by cyx-6).
Head commit for run:
045acdcfccc544261d358fd1cb8a9628b68d02fb / Yaxing Cai <ca...@gmail.com>
[WIP][REFACTOR][Python] Address PR #593 review feedback on PyObject-tying
WIP: not all review threads cleared yet (L135, L166, L311, L627 still open).
Squash of the review follow-ups so far (no behavior change except the slot
removal, which is verified equivalent):
- memory.h: collapse the templated AlignedAlloc<align> (dead after the
custom-allocator hook) + AlignedAllocRuntime into one AlignedAlloc(size, align).
- Naming/doc: TVMFFIPyRebindPyObject -> TVMFFIPyCompareAndRebindPyObject
(+ neo -> new_object), TVMFFIPyUnlockInTransit -> TVMFFIPyUnlockPublishInTransit,
make_ret local w -> reused_pyobj_space, LockClassifyActive out -> out_pyobj,
+ a TryIncRef-safety note.
- Drop extern "C" from the tie helpers (module is C++/--cplus; the C-ABI slot
callbacks already omit it); fold the redundant nullptr check in
UnlockPublishInTransit.
- Remove the TEMPORARY free-threaded tp_dealloc slot: Cython 3.2.8 ships
GH-7769/7770 (__Pyx_DeallocKeepAlive), so FT falls back to __dealloc__ like
the GIL build. Pin cython>=3.2.8 (+ uv exclude-newer-package override).
Verified: FT 3.14t suite 2342 passed + concurrency oracle clean; GIL 3.13 2367
passed. Both built against Cython 3.2.8.
Report URL: https://github.com/apache/tvm-ffi/actions/runs/28577770705
With regards,
GitHub Actions via GitBox
---------------------------------------------------------------------
To unsubscribe, e-mail: discuss-archive-unsubscribe@tvm.apache.org
For additional commands, e-mail: discuss-archive-help@tvm.apache.org