[GitHub] [hadoop] steveloughran commented on a change in pull request #2637: HADOOP-17483. Remove option to enable/disable S3A magic committer . It is always on

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #2637:
URL: https://github.com/apache/hadoop/pull/2637#discussion_r563714057



##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/MagicCommitIntegration.java
##########
@@ -128,17 +126,15 @@ public PutTracker createTracker(Path path, String key) {
    * @return a list of elements, possibly empty
    */
   private List<String> finalDestination(List<String> elements) {
-    return magicCommitEnabled ?
-        MagicCommitPaths.finalDestination(elements)
-        : elements;
+    return MagicCommitPaths.finalDestination(elements);
   }
 
   /**
    * Is magic commit enabled?
    * @return true if magic commit is turned on.
    */
   public boolean isMagicCommitEnabled() {
-    return magicCommitEnabled;
+    return true;

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org