[GitHub] [beam] MiguelAnzoWizeline commented on a change in pull request #15183: [BEAM-11983] Java Datastore - Implement IO Request Count metrics

[GitBox <gi...@apache.org>]

MiguelAnzoWizeline commented on a change in pull request #15183:
URL: https://github.com/apache/beam/pull/15183#discussion_r681906939



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/datastore/DatastoreV1.java
##########
@@ -1460,6 +1495,12 @@ private void flushBatch() throws DatastoreException, IOException, InterruptedExc
           // Break if the commit threw no exception.
           break;
         } catch (DatastoreException exception) {
+          GoogleJsonError.ErrorInfo errorInfo = getErrorInfo(exception);
+          if (errorInfo == null) {
+            serviceCallMetric.call(ServiceCallMetric.CANONICAL_STATUS_UNKNOWN);
+          } else {
+            serviceCallMetric.call(errorInfo.getReason());

Review comment:
       Change done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org