You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/03/26 19:12:18 UTC
Review Request 32540: Error in getting host components with state
INSTALL_FAILED
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen and Sumit Mohanty.
Bugs: AMBARI-4782
https://issues.apache.org/jira/browse/AMBARI-4782
Repository: ambari
Description
-------
.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 98390fd
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
Diff: https://reviews.apache.org/r/32540/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 32540: Error in getting host components with state
INSTALL_FAILED
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Березень 26, 2015, 6:25 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, line 189
> > <https://reviews.apache.org/r/32540/diff/1/?file=906765#file906765line189>
> >
> > Can you add a unit test?
fixed
> On Березень 26, 2015, 6:25 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, line 995
> > <https://reviews.apache.org/r/32540/diff/1/?file=906765#file906765line995>
> >
> > Use StringUtils.isEmpty
fixed
> On Березень 26, 2015, 6:25 після полудня, Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, line 1041
> > <https://reviews.apache.org/r/32540/diff/1/?file=906765#file906765line1041>
> >
> > Can we rename "isStateVerified" to "checkState"?
fixed
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/#review77922
-----------------------------------------------------------
On Березень 26, 2015, 6:12 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32540/
> -----------------------------------------------------------
>
> (Updated Березень 26, 2015, 6:12 після полудня)
>
>
> Review request for Ambari, Dmytro Sen, John Speidel, and Sumit Mohanty.
>
>
> Bugs: AMBARI-4782
> https://issues.apache.org/jira/browse/AMBARI-4782
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a3ede22
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 0e10e79
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 9bc7570
>
> Diff: https://reviews.apache.org/r/32540/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 32540: Error in getting host components with state
INSTALL_FAILED
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/#review77922
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/32540/#comment126265>
Can you add a unit test?
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/32540/#comment126264>
Use StringUtils.isEmpty
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
<https://reviews.apache.org/r/32540/#comment126266>
Can we rename "isStateVerified" to "checkState"?
- Sumit Mohanty
On March 26, 2015, 6:12 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32540/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 6:12 p.m.)
>
>
> Review request for Ambari, Dmytro Sen and Sumit Mohanty.
>
>
> Bugs: AMBARI-4782
> https://issues.apache.org/jira/browse/AMBARI-4782
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 98390fd
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
>
> Diff: https://reviews.apache.org/r/32540/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 32540: Error in getting host components with state
INSTALL_FAILED
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/#review78205
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On March 30, 2015, 1:30 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32540/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 1:30 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, John Speidel, and Sumit Mohanty.
>
>
> Bugs: AMBARI-4782
> https://issues.apache.org/jira/browse/AMBARI-4782
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a3ede22
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 0e10e79
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 9bc7570
>
> Diff: https://reviews.apache.org/r/32540/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 32540: Error in getting host components with state
INSTALL_FAILED
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/
-----------------------------------------------------------
(Updated Квітень 6, 2015, 4:51 після полудня)
Review request for Ambari, Dmytro Sen, John Speidel, and Sumit Mohanty.
Bugs: AMBARI-4782
https://issues.apache.org/jira/browse/AMBARI-4782
Repository: ambari
Description
-------
.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java f323920
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java f7144b8
Diff: https://reviews.apache.org/r/32540/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 32540: Error in getting host components with state
INSTALL_FAILED
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/
-----------------------------------------------------------
(Updated Березень 30, 2015, 1:30 після полудня)
Review request for Ambari, Dmytro Sen, John Speidel, and Sumit Mohanty.
Bugs: AMBARI-4782
https://issues.apache.org/jira/browse/AMBARI-4782
Repository: ambari
Description
-------
.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a3ede22
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 0e10e79
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 9bc7570
Diff: https://reviews.apache.org/r/32540/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 32540: Error in getting host components with state
INSTALL_FAILED
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/#review78204
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Март 27, 2015, 3:54 п.п., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32540/
> -----------------------------------------------------------
>
> (Updated Март 27, 2015, 3:54 п.п.)
>
>
> Review request for Ambari, Dmytro Sen, John Speidel, and Sumit Mohanty.
>
>
> Bugs: AMBARI-4782
> https://issues.apache.org/jira/browse/AMBARI-4782
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a3ede22
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 0e10e79
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 9bc7570
>
> Diff: https://reviews.apache.org/r/32540/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 32540: Error in getting host components with state
INSTALL_FAILED
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/#review78203
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
<https://reviews.apache.org/r/32540/#comment126713>
replace desiredState= with state=
- Dmytro Sen
On Март 27, 2015, 3:54 п.п., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32540/
> -----------------------------------------------------------
>
> (Updated Март 27, 2015, 3:54 п.п.)
>
>
> Review request for Ambari, Dmytro Sen, John Speidel, and Sumit Mohanty.
>
>
> Bugs: AMBARI-4782
> https://issues.apache.org/jira/browse/AMBARI-4782
>
>
> Repository: ambari
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a3ede22
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 0e10e79
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 9bc7570
>
> Diff: https://reviews.apache.org/r/32540/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 32540: Error in getting host components with state
INSTALL_FAILED
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32540/
-----------------------------------------------------------
(Updated Березень 27, 2015, 3:54 після полудня)
Review request for Ambari, Dmytro Sen, John Speidel, and Sumit Mohanty.
Bugs: AMBARI-4782
https://issues.apache.org/jira/browse/AMBARI-4782
Repository: ambari
Description
-------
.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java a3ede22
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java 6536bd5
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 639e170
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 0e10e79
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java 9bc7570
Diff: https://reviews.apache.org/r/32540/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi