[jira] [Commented] (SOLR-15919) Deprecate File based APIs in SolrZKClient and create new Path-based APIs

["Shawn Heisey (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475074#comment-17475074 ] 

Shawn Heisey commented on SOLR-15919:
-------------------------------------

From your email to dev:
{quote}It would be a fairly substantial change to the public API of SolrZkClient, which I'm not sure if we consider client facing or not. However, I feel like the change would be low risk given that we are already often converting between File and Path in the implementations.
{quote}
I could be wrong here, but I don't think we really intend for most SolrJ users to utilize the zookeeper connection directly.  I'd call that expert-level coding.  IMHO, anyone doing that sort of coding should EXPECT the API to change, especially in a major version.  If we haven't declared things like SolrZkClient as experimental, we should.

Just for giggles, I fired up eclipse and had it search all of the main branch for uses of java.io.File in the code.  It found 1755 references.  I checked some of them, and they look like they wouldn't be hard to switch over to Path.  In a lot of cases, the code has to do conversion between Path and File.  I'd like to clean all that up if we can, but because the commit would be HUGE maybe we do that in main and skip it for 9.x.

As for the specific change mentioned here ... if we're going to do that for 9.x, I think it should be 9.0 rather than 9.1, and we should clean up ALL of the zk-related solr classes, not just SolrZkClient.

> Deprecate File based APIs in SolrZKClient and create new Path-based APIs
> ------------------------------------------------------------------------
>
>                 Key: SOLR-15919
>                 URL: https://issues.apache.org/jira/browse/SOLR-15919
>             Project: Solr
>          Issue Type: Task
>            Reporter: Mike Drob
>            Priority: Major
>
> APIs like 
> {\{SolrZkClient.setData(String path, File file, boolean retryOnConnLoss)}}
> should instead support NIO Path



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org